feat(courses): integrate course API with offline-first pagination#42
feat(courses): integrate course API with offline-first pagination#42Gowreesh-A-M wants to merge 11 commits intofeat/integrate-auth-apifrom
Conversation
Gowreesh-A-M
commented
Mar 21, 2026
- Add ApiClient and ApiException for centralized HTTP handling
- Implement HttpDataSource.getCourses with page/page_size params
- Add PaginatedResponseDto to handle paginated API responses
- Update CourseRepository to track pagination state via API next field
- Add courseInitialSync provider, auth-gated and session-aware
- Show full-screen loader only on first visit with empty cache
- Show bottom pagination loader while fetching subsequent pages
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly upgrades the Study tab by integrating a real course API, moving away from static mock data. It establishes a robust offline-first architecture with efficient pagination, ensuring a smooth user experience even with large datasets or intermittent connectivity. The changes include a new centralized networking layer, refined loading state management, and an updated data model to support richer course information. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request refactors the Study tab to integrate a real backend API for course data, transitioning from static mock data to an offline-first, paginated approach. Key changes include the introduction of ApiClient and ApiException for centralized HTTP communication with JWT authentication, and an updated HttpDataSource that fetches paginated course data. The data layer is enhanced with a new PaginatedResponseDto model and the CourseDto and local Drift database (CoursesTable) now support an image field, with the database schema version incremented. The CourseRepository is refactored to manage pagination state and supports incremental fetching, persisting data locally, and providing sync state callbacks. The StudyScreen is updated to use a CustomScrollView with a ScrollController for infinite scrolling, displaying appropriate loading indicators for initial fetches and pagination. Course cards are also enhanced to display fetched course images, with a fallback to a default icon. The application configuration now defaults to using the real HTTP data source.
- Add ApiClient and ApiException for centralized HTTP handling - Implement HttpDataSource.getCourses with page/page_size params - Add PaginatedResponseDto to handle paginated API responses - Update CourseRepository to track pagination state via API next field - Add courseInitialSync provider, auth-gated and session-aware - Show full-screen loader only on first visit with empty cache - Show bottom pagination loader while fetching subsequent pages
…gination - isolated API logic into RemoteCourseDto - implemented robust URL-based next page detection - deduplicated concurrent refresh requests in repository - secured ApiClient logs with kDebugMode gate - cleaned up database migration helpers
…p DTO layer - removed onSyncStateChanged callback from repository - implemented stateless PaginationService - strict PaginatedResponseDto with domain normalization in RemoteCourseDto - separated initial and pagination sync status providers - added explicit sync error report via SnackBar
- updated design.md to reflect stateless repository - added refined architectural tasks to tasks.md
- Decouple networking from storage via generative constructors and token callbacks. - Simplify DTOs by merging remote mapping into CourseDto's smart parsing. - Refactor repository to expose raw Drift streams and move DTO mapping to providers.
Clean up redundant key checks in CourseDto.fromJson and rely on official Testpress snake_case keys for all course fields.
- Remove redundant enrollmentProvider and consolidate into courseListProvider. - Refactor StudyScreen to remove Material imports and ScaffoldMessenger. - Implement in-UI sync error notification using Design tokens and AppText. - Clean up package exports and update consumer providers.
- Rename apiClient to network in data_source_provider.dart. - Resulting generated provider is now networkProvider for consistency. - Rename private apiClient/client fields to _networkProvider in classes. - Update constructor parameters to use networkProvider named argument.
- Replace rigid NetworkProvider factories with flexible interceptor injection. - Rename tokenProvider to getToken in AuthInterceptor for clarity. - Update data source and service providers to explicitly inject AuthInterceptor. - Isolate network instances to prevent interceptor leakage across requests.
e4558a7 to
0ef834d
Compare
Update design and task files to match current networking architecture and naming conventions.
- Replace ApiClient with NetworkProvider in the course integration proposal. - Update course API spec to reflect real authentication behavior. - Remove dev-only credential requirements from the specification. - Synchronize terminology across documentation artifacts.