Skip to content

feat: Add dark mode support in core module#1032

Open
Gowreesh-A-M wants to merge 2 commits intomasterfrom
feat/dark-mode-core
Open

feat: Add dark mode support in core module#1032
Gowreesh-A-M wants to merge 2 commits intomasterfrom
feat/dark-mode-core

Conversation

@Gowreesh-A-M
Copy link
Contributor

  • Update app theme to work with both light and dark modes
  • Add dark mode colors and styles
  • Replace hardcoded colors with reusable color values

@gemini-code-assist
Copy link

Summary of Changes

Hello @Gowreesh-A-M, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates dark mode functionality into the application's core module. It transitions the main application theme to use Material Components' DayNight capabilities, ensuring that the UI automatically adapts to the system's dark or light theme setting. This change also involves creating specific values-night resource files for colors and styles, and updating existing layout files to reference these new, theme-aware color resources instead of fixed hexadecimal color codes.

Highlights

  • DayNight Theme Integration: The application's main theme has been updated to Theme.MaterialComponents.DayNight.DarkActionBar.Bridge, enabling automatic adaptation to system-wide dark or light mode settings.
  • Dark Mode Resources Added: New values-night resource files (colors.xml and styles.xml) have been introduced to define specific color and style overrides for dark mode, ensuring a consistent visual experience.
  • Hardcoded Color Replacement: Numerous hardcoded hexadecimal color values in existing layout and drawable files have been replaced with references to theme-aware color resources, improving maintainability and dark mode compatibility.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces dark mode support by updating themes to use DayNight and replacing hardcoded colors with color resources, which is a great improvement. The changes in the layout files and the vector drawable are well-executed and follow best practices for theming. My review includes a few suggestions for the newly added values-night/styles.xml file to replace newly introduced hardcoded colors with color resources. This will improve consistency and maintainability, aligning with the overall goal of this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant