fix: replace setTimeout with queueMicrotask to prevent deadlock#571
Merged
timdeschryver merged 1 commit intoMar 11, 2026
Conversation
When using vitest, setTimeout is mocked and will only advance when instructed to do so. This never happens when used within the testing library, leaving tests deadlocked. We can avoid that using queueMicrotask, which is not affected by mocked time. closes testing-library#565
timdeschryver
approved these changes
Mar 11, 2026
Member
|
@all-contributors please add @jonaskuske for code |
Contributor
|
I've put up a pull request to add @jonaskuske! 🎉 |
|
🎉 This PR is included in version 19.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@timdeschryver @jonaskuske can this please be backported to the branch of angular-testing-library that can be used in angular@20.x? I have a project not yet ready to update to angular 21 but I think we've been plagued by this bug for a while and want to confirm this resolves it for us. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using vitest, setTimeout is mocked and will only advance when instructed to do so (unless using
vi.useFakeTimers({ shouldAdvanceTime: true }). This never happens when used within the testing library, leaving tests deadlocked. We can avoid that using queueMicrotask, which is not affected by mocked time.closes #565