Fix upperseq definition in Example_6_4_9#472
Open
Shaunticlair wants to merge 3 commits intoteorth:mainfrom
Open
Fix upperseq definition in Example_6_4_9#472Shaunticlair wants to merge 3 commits intoteorth:mainfrom
Shaunticlair wants to merge 3 commits intoteorth:mainfrom
Conversation
This minus sign shouldn't be here, I don't think. 1. it would better mirror lowerseq 2. the largest term should always be the next positive one.
Example_6_4_9.limsup showed up twice previously, the second instance looked like it should contextually be Example_6_4_10.limsup
Contributor
Author
|
Not sure why it's failing to build? The changes I made don't seem erroneous. |
rkirov
approved these changes
Mar 30, 2026
Contributor
rkirov
left a comment
rkirov
left a comment
There was a problem hiding this comment.
yep, the minus sign is a typo - https://github.com/rkirov/analysis/blob/main/analysis/Analysis/Section_6_4.lean#L490
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This minus sign shouldn't be here, I don't think. 1. it would properly mirror lowerseq 2. the sup should always be the next positive term.