Repository navigation
Keep weight/bias hovercard open while editing - #256
Open
JanickSpielmann wants to merge 1 commit into
Open
JanickSpielmann wants to merge 1 commit into
JanickSpielmann wants to merge 1 commit into
Conversation
Previously the hovercard was tied to the mouse position: as soon as the pointer left the thin invisible link path, mouseleave closed the card and the input field with it, even in the middle of typing a value. Now clicking into the card pins it. It stays open when the pointer leaves the link or enters another one, and closes on Enter, Escape or a mouse press outside of the card. Plain hovering without a click behaves as before. The invisible hover path is also widened from 8 to 14 px to make the link easier to hit. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01K4U4bLzdEj7UET5p21Ltu3
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
ok did that |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The weight/bias hovercard is tied to the mouse position. The input field only lives inside the card, and the card is hidden by
mouseleaveon the thin invisible link path. So while typing a new weight, a small mouse movement off the line closes the card and the edit is lost.Change
Clicking into the card now pins it. While pinned,
updateHoverCardignoresmouseleaveandmouseenterfrom links and neurons, so the card stays open when the pointer drifts away. The card closes on Enter, Escape, or a mouse press outside of it. Plain hovering without a click behaves exactly as before.The invisible hover path of links is also widened from 8 px to 14 px so links are easier to hit.
Testing
Built with
npm run buildand tested in Chromium with Playwright: hover opens the card, click shows the input, moving the pointer 120 px away keeps the card open, typing works, Enter/Escape/outside click close it, and hover without click still hides the card on leave. No console errors. I did not verify on touch devices.Generated with Claude Code (https://claude.com/claude-code)
https://claude.ai/code/session_01K4U4bLzdEj7UET5p21Ltu3