Fix static shape check in crd_decode#2753
Open
vankov wants to merge 1 commit intotensorflow:masterfrom
Open
Conversation
When checking whether the shape of 'potentials' is static in crf_decode, you need to check whether potentials.shape[1].value is None, and not potentials.shape[1] (which is a Dimension object and is never equal to None).
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
You are owner of some files modified in this pull request. |
Contributor
|
Do you have a test extension to cover/check your case? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When checking whether the shape of 'potentials' is static in crf_decode, you need to check whether potentials.shape[1].value is None, and not potentials.shape[1] (which is a Dimension object and is never equal to None).
Description
Brief Description of the PR:
Fixes # (issue)
Type of change
Checklist:
How Has This Been Tested?
If you're adding a bugfix or new feature please describe the tests that you ran to verify your changes:
I've checked the resulting graphs using both static and dynamic shapes with and feeding either single item or multiple item sequences.