jitter poller timeout #8927
Open
jitter poller timeout #8927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ease issues when we have large amounts of pollers all timing out together.
dnr
reviewed
Jan 5, 2026
| // returned to the handler before a context timeout error is generated. | ||
| ctx, cancel := contextutil.WithDeadlineBuffer(ctx, pm.LongPollExpirationInterval(), returnEmptyTaskTimeBudget) | ||
| // We also want to jitter the timeout a bit to ease stampeding hurd issues when the pollers all timeout | ||
| // together. However take caution to only do this for non forwarded tasks. |
Contributor
There was a problem hiding this comment.
do you mean "non-forwarded polls"? also is the condition backwards? if pollMetadata.forwardedFrom == "" that's a poll from a client, so it should jitter, otherwise it shouldn't?
also I want to go over the logic again and test it.. most/all sdks actually set the poll grpc timeout to 70s, and LongPollExpirationInterval is 60s, so actually I think a "10s" buffer is a no-op, based on the current logic in WithDeadlineBuffer. I think we need to subtract it from LongPollExpirationInterval. see the comments in slack.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ease issues when we have large amounts of pollers all timing out together.
What changed?
Add a jitter to our buffer for poller context timeouts
Why?
we were running in to issues when we had larger numbers of pollers all timing out together, this should spread out that load a bit more.
How did you test it?