Open
Conversation
mjameswh
reviewed
Mar 17, 2026
|
|
||
| Scale pollers based on task queue throughput. If you observe high schedule-to-start latency, increase the number of pollers or add more workers. | ||
|
|
||
| ## Sessions |
There was a problem hiding this comment.
I think it's pertinent to mention, but:
- We should call out limitations of that API (there are a few reasons we never ported that one to other SDKs; I'd suggest doing some research on this, there's been a lot said about that already).
- We should point out that it is mostly equivalent to the worker-specific task queue pattern (again, I'll let you do some research).
mjameswh
reviewed
Mar 17, 2026
| converter.NewProtoJSONPayloadConverter() | ||
| ``` | ||
|
|
||
| Both are included in the default data converter. SDK v1.26.0+ migrated from gogo/protobuf to google/protobuf. If you need backward compatibility with older payloads encoded with gogo, use the `LegacyTemporalProtoCompat` option. |
There was a problem hiding this comment.
I'd suggest adding the release date next to this version number. It seems likely that the very next agent's step after reading that sentence will be to search for that date to determine whether this backward compatibility concern is likely to apply to the user.
mjameswh
reviewed
Mar 17, 2026
|
|
||
| Temporal provides durable execution through **History Replay**. When a Worker restores workflow state, it re-executes workflow code from the beginning. This requires the code to be **deterministic**. See `references/core/determinism.md` for a deep explanation. | ||
|
|
||
| ## Forbidden Operations |
There was a problem hiding this comment.
There's a lot of duplication between this file and determinism-protection.md, and possibly with other files in the "shared" content at the root of the repo.
Not a huge concern, but that consumes tokens. You may want to revisit and optimize this at some point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Adds support for Go.
This PR will be merged instead of #6, which is the much older and way less complete version of Go. Once approved I will force-push these commits to the branch of #6, in case anyone was actually using #6 for testing.