💥 feat(sdk): remove usage of anyhow from public error types#1326
Open
chris-olszewski wants to merge 6 commits into
Open
💥 feat(sdk): remove usage of anyhow from public error types#1326chris-olszewski wants to merge 6 commits into
anyhow from public error types#1326chris-olszewski wants to merge 6 commits into
Conversation
Sushisource
approved these changes
Jun 11, 2026
Sushisource
left a comment
Member
There was a problem hiding this comment.
Niiiice!
Maybe update agents.md and/or the readme with info that we shouldn't depend on anyhow in public API of the SDK?
Opengrep — new findings
Suppress findingsAdd a |
b817a7e to
1550e29
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
ApplicationFailureto be backed by boxed errorsWorkflowErrorto be backed by boxed errorsWorkflowContext::force_task_failnow works with boxed errors instead ofanyhowWorkflowTerminationfromApplicationFailure(allows?to work well in workflow code)anyhowwrappingThese are technically breaking changes, but most code should continue to work without issue as
anyhow::ErrorimplementsInto<Box<dyn Error + Send + Sync>>Each commit is reviewable on its own.
Why?
Reduce our usage of
anyhowin public facing APIsChecklist
Closes N/A
How was this tested:
Existing tests
Any docs updates needed?
Once released we can update docs to no longer have
ApplicationFailure::new(anyhow!("boom"))