Support be-js connected code in funtests by tjpalmer · Pull Request #470 · temperlang/temper

tjpalmer · 2026-07-28T22:51:35Z

Make be-js always produce a .internal.js that always exports all top levels
- This actually net cuts over 100 lines of code in this pr
- Net line increase is from tests, connected code support, and pretty class names
Make be-js class names pretty when possible, so connected code knows how to reference them
Support connected code in a separate module so its imports don't clutter Temper-built module namespace

Signed-off-by: Tom <tom@temper.systems>

tjpalmer · 2026-07-28T23:42:18Z

+            if (translation.dependencyCategory == DependencyCategory.Test) {
+                testPaths.add(translation.outPath)
            }
        }


I started deleting things I planned to replace then also kept deleting things that weren't being used.

tjpalmer · 2026-07-28T23:42:48Z

-                        prepareTesting(program, stdTestingRelativePath)
+                        jsDependencies = jsDependencies
+                            .withTestDependency(JsDependency("mocha", "^10.0.0", null))
+                            .withTestDependency(JsDependency("mocha-junit-reporter", "^2.0.2", null))


Only had 3 lines left from the other fun, so I just inlined here.

tjpalmer · 2026-07-28T23:42:58Z

                .map translations@{ (outPath, program, tmpLModule) ->
                    if (outPath in testPaths) {
-                        // Functional tests still uses renamed std imports.
-                        // TODO Remove this if we standardize funtests to same imports as elsewhere.


Apparently TODONE.

tjpalmer · 2026-07-28T23:48:38Z

+                val outName = outPath.last().fullName
+                // Skip internal modules.
+                outName.endsWith(INTERNAL_EXTENSION) && continue@translations
+                outName.startsWith("_") && continue@translations


Instead of connected.internal.js, I used _connected.js since it's not really an internal version of a separate module or whatever. I'm unsure what best naming is, but this matches my most common _connected naming across backends in #465.

Meanwhile, I don't see a need to "export" internals, so this now avoids them.

tjpalmer · 2026-07-28T23:50:08Z

-        val stdTestingPrefix = stdTestingRelativePath ?: run {
-            val std = libraryConfigurations.byLibraryName.getValue(DashedIdentifier.temperStandardLibraryIdentifier)
-            "${std.jsLibraryName()}/$TESTING_BASENAME"
-        }


I looked at funtest-generated code, and it was even also referencing the sibling std dir in the lock file. I didn't change anything with that in this pr, I don't think. I think it's just vestigial concerns above. (Unless there was something in the other code I also deleted/replaced in this pr.)

tjpalmer · 2026-07-29T19:23:56Z

            is OutDir -> {
                console.groupIf(f is OutSubDir, "${f.name}/") {
-                    f.files.forEach { dump(it) }
+                    f.files.sortedBy { it.name }.forEach { dump(it) }


Extra internal files in ReplTest translation got different order on my machine vs in ci, so I sort them now. I think this is ok for the actual repl.

I think we take pains not to import and reexport, but might be worth checking that a name in one repl chunk continues to mask a name from an earlier repl chunk.

I think we take pains not to import and reexport, but might be worth checking that a name in one repl chunk continues to mask a name from an earlier repl chunk.

I'll look into that.

I don't see old repl chunks even showing up, but I do get an export error on translation. This is on main:

$ class A {} interactive#0: A__0 $ class B { public a: A = new A() } interactive#1: B__0 $ translate(1, "java") 1: class B { public a: A = new A() } ⇧ [interactive#1:1+20-21]: interactive#0 does not export symbol A__0 Translated java for interactive#1 interactive/ src/ main/ java/ interactive/ i0001/ B.java: text/x-java-source package interactive.i0001; final class B { public final A a; public B() { A t_15 = new A(); this.a = t_15; } public A getA() { return this.a; } } I0001Main.java: text/x-java-source package interactive.i0001; import temper.core.Core; import static interactive.i0001.I0001Global.export; public final class I0001Main { private I0001Main() { } public static void main(String[] args) { Core.initSimpleLogging(); Core.doNothing(export); Core.waitUntilTasksComplete(); } } I0001Global.java: text/x-java-source package interactive.i0001; public final class I0001Global { private I0001Global() { } public static Class export; static { export = return__13; } } I0001Main.java.map: application/json { "version": 3, "file": "java/interactiv⋯,SAAiC,CAAA,AAAjC,MAAiC;AAAA;AAAA;AAAA" } I0001Global.java.map: application/json { "version": 3, "file": "java/interactiv⋯BAAA;AAAjC;AAAiC,iBAAAA,UAAA;AAAA;AAAA" } B.java.map: application/json { "version": 3, "file": "java/interactiv⋯,WAAAF,CAAA;AAAA,oBAAAC,CAAA;AAAA;AAAA" } interactive#2: void

I get the same error for explicit export of the classes, by the way.

Let me know if I should write up an issue for that, but even separate from that, I haven't found the name masking yet in the relevant segment of code or things that it calls, but I might be overlooking it.

fun dump(f: OutFile): Unit = when (f) { is OutDir -> { console.groupIf(f is OutSubDir, "${f.name}/") { f.files.forEach { dump(it) } } } is OutRegularFile -> dumpBinary( f.name, f.mimeType, outputRoot.byteContentOf(f.path) ?: WrappedByteArray.empty, ) }

This seems just to do recursive dir tree dumping. I don't see it in dumpBinary either, but maybe I'm overlooking it.

Anyway, overall, I don't see issues in the code for this pr yet.

That does seem like a bug.

You can write up an issue if you like and/or you could put an @Ignored ReplTest case in there.

tjpalmer · 2026-07-29T19:24:23Z

                    |          interactive/
                    |            i0000/
+                    |              .*
                    |              I0000Main[.]java: text/x-java-source


After sorting, Main is now longer first.

tjpalmer · 2026-07-29T19:27:00Z

@@ -0,0 +1,20 @@
+// @ts-check
+import { Hidden } from "./work.internal.js";


Connected code has to import what it wants from internal. And it's because of arbitrary top-level import namespace pollution that I've pulled it out.

Note that there's cyclic imports here because this module is also imported by the translated internal module. I haven't tested with side effects in both, but this is at least fine without top-level side effects here.

And I only use Hidden for static typing in this module, so it's not actually needed, but this proves I can get it imported at least.

tjpalmer · 2026-07-29T19:28:13Z

@@ -0,0 +1,20 @@
+// @ts-check
+import { Hidden } from "./work.internal.js";
+import { Support } from "./_support.js";


And testing additional connected support code like for other backends.

tjpalmer · 2026-07-29T19:28:27Z

+};
+
+/**
+ * @param {Hidden} hidden


Here's the only use of Hidden.

Signed-off-by: Tom <tom@temper.systems>

mikesamuel

Still looking

mikesamuel · 2026-08-03T18:23:52Z

+    private val exportedIds = mutableListOf<Js.Identifier>()
+    private val importsFromProdToTest = mutableSetOf<JsIdentifierName>()
+    private val prodTopIds = mutableSetOf<ResolvedName>()
+    private var hasConnected = false


How much of this import tracking is JS specific?

mikesamuel · 2026-08-03T18:26:00Z

            is OutDir -> {
                console.groupIf(f is OutSubDir, "${f.name}/") {
-                    f.files.forEach { dump(it) }
+                    f.files.sortedBy { it.name }.forEach { dump(it) }


I think we take pains not to import and reexport, but might be worth checking that a name in one repl chunk continues to mask a name from an earlier repl chunk.

mikesamuel · 2026-08-05T00:58:33Z

+            "moduleMinimal" to """
+                |
+                |export {} from "./implement.internal.js";
+            """.trimMargin(),


Having the export {} is actually a good thing since some JS engines will treat content as a ScriptBody if it has no import or export declarations, and unlike a ModuleBody those are not strict mode unless explicitly specified.

mikesamuel · 2026-08-05T00:59:30Z

            is OutDir -> {
                console.groupIf(f is OutSubDir, "${f.name}/") {
-                    f.files.forEach { dump(it) }
+                    f.files.sortedBy { it.name }.forEach { dump(it) }


That does seem like a bug.

You can write up an issue if you like and/or you could put an @Ignored ReplTest case in there.

tjpalmer added 8 commits July 24, 2026 17:48

Simplify internal js and exports

1b3117e

Signed-off-by: Tom <tom@temper.systems>

Pass tests on full internal

90f64a2

Signed-off-by: Tom <tom@temper.systems>

Pass test test and build test

1a3ef4c

Signed-off-by: Tom <tom@temper.systems>

Clean more unused

ce4651f

Signed-off-by: Tom <tom@temper.systems>

Connect js except ugly type names

9642fd3

Signed-off-by: Tom <tom@temper.systems>

Pass tests

4a3bf4c

Signed-off-by: Tom <tom@temper.systems>

Fix lint

34cefd4

Signed-off-by: Tom <tom@temper.systems>

Fix translator test

0fa29fb

Signed-off-by: Tom <tom@temper.systems>

tjpalmer changed the title ~~Connected js~~ Support be-js connected code in funtests Jul 28, 2026

tjpalmer added 3 commits July 29, 2026 09:26

Use single prod mod for doc

60a57b8

Signed-off-by: Tom <tom@temper.systems>

Fix repl and layout tests

68c782e

Signed-off-by: Tom <tom@temper.systems>

Sort repl translations

d338a5d

Signed-off-by: Tom <tom@temper.systems>

tjpalmer commented Jul 29, 2026

View reviewed changes

Update test matrix

3fc4f0a

Signed-off-by: Tom <tom@temper.systems>

tjpalmer marked this pull request as ready for review July 29, 2026 20:21

Merge branch 'main' into connected-js

1aaec20

Signed-off-by: Tom <tom@temper.systems>

tjpalmer mentioned this pull request Jul 31, 2026

Userspace @connected methods #456

Open

7 tasks

mikesamuel reviewed Aug 3, 2026

View reviewed changes

mikesamuel approved these changes Aug 5, 2026

View reviewed changes

		@@ -0,0 +1,20 @@
		// @ts-check
		import { Hidden } from "./work.internal.js";

Uh oh!

Conversation

tjpalmer commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mikesamuel left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

tjpalmer commented Jul 28, 2026 •

edited

Loading