Skip to content

✨ add StrictMerge option and improve list-limit handling in decoder tests #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
techouse merged 9 commits into from
May 28, 2026
Merged

✨ add StrictMerge option and improve list-limit handling in decoder tests #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6f5b191
:arrow_up: bump qs from 6.15.1 to 6.15.2
techouse May 28, 2026
43e8a62
feat(decode): align with qs 6.15.2 parsing
techouse May 28, 2026
6b2cc37
fix(encode): respect delimiter after charset sentinel
techouse May 28, 2026
983056d
docs(decode): document qs 6.15.2 parity options
techouse May 28, 2026
125d610
refactor(tests): improve test method names for clarity and consistency
techouse May 28, 2026
48c84f4
refactor(tests): rename test methods for improved clarity and consist…
techouse May 28, 2026
7415637
refactor(Utils): remove redundant overflow handling logic in Combine …
techouse May 28, 2026
221481c
test(decode): add tests for handling comma overflow in lists and maps
techouse May 28, 2026
8e9752f
fix(Decoder): correct list limit check in ParseListValue method
techouse May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion QsNet.Comparison/js/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@
"license": "BSD-3-Clause",
"packageManager": "pnpm@11.1.3",
"dependencies": {
"qs": "^6.15.1"
"qs": "^6.15.2"
}
}
10 changes: 5 additions & 5 deletions QsNet.Comparison/js/pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 5 additions & 1 deletion QsNet.Tests/DecodeOptionsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ public void CopyWith_NoModifications_ShouldReturnIdenticalOptions()
InterpretNumericEntities = true,
ParameterLimit = 200,
ParseLists = true,
StrictMerge = false,
StrictNullHandling = true
};

Expand All @@ -49,6 +50,7 @@ public void CopyWith_NoModifications_ShouldReturnIdenticalOptions()
newOptions.InterpretNumericEntities.Should().BeTrue();
newOptions.ParameterLimit.Should().Be(200);
newOptions.ParseLists.Should().BeTrue();
newOptions.StrictMerge.Should().BeFalse();
newOptions.StrictNullHandling.Should().BeTrue();

newOptions.Should().BeEquivalentTo(options);
Expand Down Expand Up @@ -91,6 +93,7 @@ public void CopyWith_WithModifications_ShouldReturnModifiedOptions()
interpretNumericEntities: false,
parameterLimit: 200,
parseLists: true,
strictMerge: false,
strictNullHandling: false
);

Expand All @@ -108,6 +111,7 @@ public void CopyWith_WithModifications_ShouldReturnModifiedOptions()
newOptions.InterpretNumericEntities.Should().BeFalse();
newOptions.ParameterLimit.Should().Be(200);
newOptions.ParseLists.Should().BeTrue();
newOptions.StrictMerge.Should().BeFalse();
newOptions.StrictNullHandling.Should().BeFalse();
}

Expand Down Expand Up @@ -362,4 +366,4 @@ public void ShouldNotThrowForUtf8OrLatin1CodePageWithCustomFallbacks()
utf8Act.Should().NotThrow();
latin1Act.Should().NotThrow();
}
}
}
Loading
Loading