feat: Add VariantLine type to card variant_detailed - #1925
Open
thomas-bassett wants to merge 1 commit into
Open
Conversation
Introduces a new `VariantLine` type ('main' | 'parallel' | 'restricted' | 'exclusive') to categorize variant availability (booster packs, precon products, event-restricted, or event-exclusive). Updates interfaces, API definitions, translations (de/es/fr/it/pt), and compiler utilities to support the new field, defaulting to 'main' when unspecified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Adds
lineto variant detailed. this line is used to separate variants based on how they are obtained. raised out of the issue of trying to distinguish between a holo released in booster packs and a non-holo variant released in build and battle kits.This defines four line types:
Main: found in booster packs
Parallel: found in specific products bbk, pre constructed
Restricted: given out at a specific event or promotion
Exclusive: given out at a specific event for either working, topcut, winners. or for performing a specific job: professor program.
variants currently default to main line at compile time. so in theory only need to adjust the line for the other 3
none of these lines are locked in a new reasons can be added to expand on them. if a card is available in two of the lines always use the more available line. i.e. precons will likely have main line cards in them. those cards should be treated as main line and the non-holo holos should be treated as parallel as they are not available in booster packs