fix(soak): apply initial favorites corpus - #88
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The manual Favorites filter was applied after playback had already started. In the 1-cell pilot,
Filter: FAVORITES (67 items)appeared about one minute into a two-minute phase, leaving the first half on the full 801-item library. That is not fixed-corpus evidence.Change
HYPERWALL_SOAK_FILTER=favoritesbehavior that selects Favorites immediately after metadata loads and before cell-start timers run.self.all_itemsintact so normal A/F controls still work.run.env.This supports fixed-corpus evidence for #75, #76, and #79. It does not close those issues and does not change Windows/Linux defaults.
Verification
python3 tests/run_all.py: PASSpython3 -m compileall -q hyperwall tests: PASSbash -n soak_wall.sh launch.sh: PASSed8f6525914fbdb38fd3c3fc22c195930c1e1dc2778451066634d31b518bb4e2