fix(macos): detect named external displays - #87
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On the M5 target,
system_profiler SPDisplaysDataTypereports the twoLG ULTRAGEAR+displays under aDisplays:block but omits bothDisplay TypeandConnection Type. The soak launcher therefore wroteexternal_display_observed=0for a valid docked-clamshell setup.Change
Displays:.Display TypeandConnection Typemarkers.This is related to #79. It does not close the issue or promote any cell count.
Verification
python3 tests/run_all.py: PASSpython3 -m compileall -q hyperwall tests: PASSbash -n soak_wall.sh: PASSexternal_display_observed=1.Native acceptance remains separate and incomplete until the fresh fixed-corpus runs are completed.