Refactor/2026 03 changing how result set data is stored#679
Merged
takapi327 merged 38 commits intoseries/0.7.xfrom Mar 27, 2026
Merged
Conversation
…r/2026-03-Changing-how-ResultSet-data-is-stored
…String Conversion
… of github.com:takapi327/ldbc into refactor/2026-03-Changing-how-ResultSet-data-is-stored
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation Details
Refactored the design to change the internal data storage format of the ResultSet from decoded strings (
Array[Option[String]]) to raw byte arrays (Array[Byte]), with decoding performed lazily whenget*()methods are called.In the previous implementation, when receiving row data from the MySQL server, the values of all columns were converted to the String type and stored. This approach had the following issues:
getInt()or similar functions, a double conversion occurred: byte → string → numeric.Pull Request Checklist
References