Adding python/add_user_to_pulse_metric_subscription.py.#91
Open
dzucker-tab wants to merge 1 commit intomasterfrom
Open
Adding python/add_user_to_pulse_metric_subscription.py.#91dzucker-tab wants to merge 1 commit intomasterfrom
dzucker-tab wants to merge 1 commit intomasterfrom
Conversation
jacalata
requested changes
Jan 10, 2025
| # LUID of a Pulse Metric: | ||
| # The LUID is the last part of the metric URL. | ||
| # It would be 5aa997e2-07ed-4c60-bda5-154ca9f8d013 for the URL below | ||
| # - https://dub01.online.tableau.com/pulse/site/darkplatypus/metrics/5aa997e2-07ed-4c60-bda5-154ca9f8d013 |
Contributor
There was a problem hiding this comment.
could make this url more generic by removing dub01 and sub out darkplatypus.
| if next_page_token: | ||
| url = f'{server_url}/api/-/pulse/subscriptions?page_size={page_size}&page_token={next_page_token}' | ||
| else: | ||
| url = f'{server_url}/api/-/pulse/subscriptions?page_size={page_size}' |
Contributor
There was a problem hiding this comment.
Ideally this would use the make_tableau_request method
| # Date: 10/24/2024 | ||
| # Description: | ||
| # This script subscribes a user to a Pulse metric on Tableau Cloud Site. | ||
| # The script utilizes the Tableau Server Client (TSC) and requests libraries |
Contributor
There was a problem hiding this comment.
Hm, it shouldn't use TSC. If it does then it shouldn't be writing it's own make_tableau_request methods etc.
Or perhaps it could be moved to the tsc repo and used as a sample there?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.