Fix grammar and typos#379
Merged
Merged
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
EricccTaiwan
approved these changes
May 26, 2026
EricccTaiwan
left a comment
EricccTaiwan
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. I think ioctl's was intended as a plural, but ioctls is more consistent with how the kernel docs handle similar terms (syscalls, kprobes, etc.).
Thanks!
jserv
reviewed
May 26, 2026
| * | ||
| * Until now we could have used cat for input and output. But now | ||
| * we need to do ioctl's, which require writing our own process. | ||
| * we need to do ioctls, which require writing our own process. |
Contributor
There was a problem hiding this comment.
Use different notations for ioctl and s.
Collaborator
There was a problem hiding this comment.
Agree, maybe "ioctls"?
Contributor
Author
|
Replaced with |
Contributor
It is better. |
Contributor
|
Thank @deantee for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix grammar errors and typos across
README.md,lkmpg.tex, example code, and CI/scripts files. Covers verb forms, missing articles, wrong prepositions, pluralization errors, typos, and pronoun mistakes.Summary by cubic
Fix grammar, typos, and wording across
README.md,lkmpg.tex, examples, and CI/scripts, including ioctl terminology. No functional changes; builds and examples behave the same.Written for commit 9faa42d. Summary will update on new commits. Review in cubic