Conversation
The 3 second budget after "wheel down 5" still flaked the violawww- differential job on heavily loaded GitHub runners. The compat-side initial.png and scrolled.png came back bit-identical (changed_ratio 0.00000), recoverable by a plain rerun. Match the 6 second budget that the smoke replay tests/ui/replays/violawww-scroll.replay already uses for the analogous in-process step. wait-converge would be the principled replacement but is not yet a drop-in: the xdotool backend silently ignores its arguments and falls back to a 500 ms sleep, and the C-side detector can declare quiet on pre-input idle before vw has produced any Expose/Present activity. Record both gotchas in the comment so the cheap delay bump is not relitigated as a missed wait-converge opportunity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 3 second budget after "wheel down 5" still flaked the violawww-differential job on heavily loaded GitHub runners. The compat-side initial.png and scrolled.png came back bit-identical (changed_ratio 0.00000), recoverable by a plain rerun. Match the 6 second budget that the smoke replay tests/ui/replays/violawww-scroll.replay already uses for the analogous in-process step.
wait-converge would be the principled replacement but is not yet a drop-in: the xdotool backend silently ignores its arguments and falls back to a 500 ms sleep, and the C-side detector can declare quiet on pre-input idle before vw has produced any Expose/Present activity. Record both gotchas in the comment so the cheap delay bump is not relitigated as a missed wait-converge opportunity.
Summary by cubic
Increase the post-scroll settle time in the differential replay to 6s to stop flaky failures on busy GitHub runners. This matches the 6s budget used by the in-process smoke replay.
Bug Fixes
wait-convergeisn’t used yet: thexdotoolbackend ignores args and sleeps 500 ms, and the detector can converge before Expose/Present.Refactors
Written for commit e2ca752. Summary will update on new commits.