-
Notifications
You must be signed in to change notification settings - Fork 18
Add custom predicate extensions via [[predicate]] #238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nikomatsakis
merged 13 commits into
symposium-dev:main
from
nikomatsakis:custom-predicates
Jun 9, 2026
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
80f057b
Add custom predicate extensions via [[predicate]]
nikomatsakis 7210fb3
Integrate custom predicate evaluator into PredicateContext
nikomatsakis f8d45ee
Consolidate predicate name validation and fix CrateList comma parsing
nikomatsakis 03ffdc3
Reject function-call syntax in the `crates` field
nikomatsakis aee2901
Add tests for field syntax boundary enforcement
nikomatsakis d009da9
Fix CI: replace /bin/true with script-based test helpers
nikomatsakis 873b488
Add integration tests for argument passing and witness-driven crate s…
nikomatsakis e5c940c
Fail predicate when stdout is non-empty but not valid witness JSON
nikomatsakis d3b0b92
Fail predicate on any malformed witness entry
nikomatsakis 053c8c1
Document and test that empty/whitespace args are not passed
nikomatsakis a704384
Add integration tests for argument passing and witness-driven crate s…
nikomatsakis 66e50dc
Introduce CustomPredicateRegistry newtype
nikomatsakis cc56f8e
Document that custom predicates are globally available across plugins
nikomatsakis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.