Conversation
grynspan
force-pushed
the
jgrynspan/semver-prerelease-ids
branch
from
September 10, 2026 14:44
544e57c to
6e3807e
Compare
grynspan
changed the title
ABI.VersionNumberABI.VersionNumber
grynspan
added
enhancement
grynspan
marked this pull request as ready for review
September 10, 2026 15:46
grynspan
requested review from
briancroom,
harlanhaskins,
jerryjrchen and
stmontgomery
as code owners
September 10, 2026 15:46
| return "-" + prereleaseIDs.joined(separator: ".") | ||
| } | ||
|
|
||
| init?<S>(prereleaseID: S) where S: StringProtocol, S.SubSequence == Substring { |
Contributor
There was a problem hiding this comment.
I'm a little unclear how the changes in this file connect to the rest of the PR
stmontgomery
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for representing development versions of the JSON schema independently of release versions by specifying the
"-dev"suffix, e.g.--event-stream-version 6.5-dev.This is useful if we want to enable functionality only on a development branch, for instance. A separate PR will adopt this new logic when parsing
VERSION.txtso we always know what our own branch is, which will makeABI.version(forVersionNumber:)play nicer whenevermainmoves to a new version (shout-out to @bkhouri for noticing that"--event-stream-version 6.5"didn't work after we branchedrelease/6.4and retargettedmainuntil we explicitly addedABI.v6_5.).This PR adds the necessary infrastructure to support other suffixes in the future that can be used to enable or disable functionality dynamically. (No, I don't have specific ideas in mind, it's just a useful tool for the toolbox.)
Checklist: