Skip to content

Leading space fail #773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gintsgints wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Leading space fail #773

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
871496d
add test for function ending with space fail
gintsgints Jul 12, 2026
27518ba
fix(treesitter): do not fail when there is a space after procedure
gintsgints Jul 12, 2026
00abd71
Merge branch 'main' into leading_space_fail
gintsgints Jul 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions crates/pgls_treesitter/src/context/ancestors.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,17 @@ impl ScopeTracker {
}

pub fn register<'a>(&mut self, node: tree_sitter::Node<'a>, position: usize) {
if SCOPE_BOUNDARIES.contains(&node.kind()) {
// The `program` root node is never registered directly, so the first node

@gintsgints gintsgints Jul 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure. Might be this comment is too much and should be removed.

// we see is one of its children. Usually that's a scope boundary (a
// statement, block, ...), but it can also be a stray token such as a
// trailing `;` – in which case we still need a base scope for it.
if SCOPE_BOUNDARIES.contains(&node.kind()) || self.scopes.is_empty() {
self.add_new_scope(node);
}

self.scopes
.last_mut()
.unwrap_or_else(|| panic!("No top-level grammar-rule found. Please create an issue with the entire Postgres file, noting cursor/hover position."))
.expect("a scope was just ensured to exist")
.ancestors
.register(node, position);
}
Expand Down Expand Up @@ -165,6 +169,11 @@ mod tests {
assert_no_panic_for_all_positions("-- a comment\nSELECT 1;");
}

#[test]
fn plpgsql_function_with_leading_space() {
assert_no_panic_for_all_positions("BEGIN END; ");
}

#[test]
fn issue_704_regression() {
let statements = vec![
Expand Down
Loading