Update pre-commit config to use file, type and type_or instead of exc…#248
Open
samaloney wants to merge 4 commits intosunpy:mainfrom
Open
Update pre-commit config to use file, type and type_or instead of exc…#248samaloney wants to merge 4 commits intosunpy:mainfrom
samaloney wants to merge 4 commits intosunpy:mainfrom
Conversation
samaloney
commented
Feb 26, 2026
Comment on lines
+53
to
+54
| # Uncomment to make sure the ecludes match something | ||
| # - id: check-useless-excludes |
Member
Author
There was a problem hiding this comment.
In newly minted repo (hence test) this would fail because there are no files in extern or data
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch to specifying the type and file we want the checks to run on rather than excluding those that we don't. I think this is more explicit and I think marginally more maintainable. If we add
.mdfiles just need to addmarkdownto thetypesortypes_orNeed to agree the type which checks should run on closes #247