Skip to content

Shearwater: Fix Parsing of the GNSS Location. #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mikeller wants to merge 1 commit into
base: Subsurface-DS9
Choose a base branch
from
+8 −3
Open

Shearwater: Fix Parsing of the GNSS Location. #113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/shearwater_predator_parser.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,9 @@

#define UNDEFINED 0xFFFFFFFF

#define GNSS_FIX_2D 2
#define GNSS_FIX_3D 3

typedef struct shearwater_predator_parser_t shearwater_predator_parser_t;

typedef struct shearwater_predator_gasmix_t {
Expand Down Expand Up @@ -1100,11 +1103,13 @@ shearwater_predator_parser_get_field (dc_parser_t *abstract, dc_field_type_t typ
case DC_FIELD_LOCATION:
if (parser->opening[9] == UNDEFINED || parser->logversion < 17)
return DC_STATUS_UNSUPPORTED;

unsigned int gnss_status = data[parser->opening[9] + 16];
if (!(gnss_status == GNSS_FIX_2D || gnss_status == GNSS_FIX_3D))
return DC_STATUS_UNSUPPORTED;
Comment on lines 1103 to +1109
Comment on lines +1107 to +1109

latitude = (signed int) array_uint32_be (data + parser->opening[9] + 21);
longitude = (signed int) array_uint32_be (data + parser->opening[9] + 25);
if ((latitude == 0 && longitude == 0) ||
(latitude == -1 && longitude == -1))
return DC_STATUS_UNSUPPORTED;
location->latitude = latitude / 100000.0;
location->longitude = longitude / 100000.0;
location->altitude = 0.0;
Expand Down
Loading