Skip to content

fix: stop the auto-refresh timer on unmount (it repaints over other plugins) #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AJV009 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: stop the auto-refresh timer on unmount (it repaints over other plugins) #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions dist/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,11 @@ function toast(msg, duration = 3500) {

// ── Main plugin ────────────────────────────────────────────────────────

// Set by mount() so unmount() can stop the auto-refresh timer, which
// otherwise keeps firing and re-rendering into a container the host has
// already handed to another plugin.
let activeStopAuto = null;

export function mount(container, api) {
let sessions = [];
let loading = false;
Expand Down Expand Up @@ -356,9 +361,11 @@ export function mount(container, api) {
render();
fetchSessions();
if (autoRefresh) startAuto();
activeStopAuto = stopAuto;
}

export function unmount(container) {
if (activeStopAuto) { activeStopAuto(); activeStopAuto = null; }
container.innerHTML = '';
const styles = document.getElementById('sm-styles');
if (styles) styles.remove();
Expand Down
7 changes: 7 additions & 0 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,11 @@ function toast(msg, duration = 3500) {

// ── Main plugin ────────────────────────────────────────────────────────

// Set by mount() so unmount() can stop the auto-refresh timer, which
// otherwise keeps firing and re-rendering into a container the host has
// already handed to another plugin.
let activeStopAuto = null;

export function mount(container, api) {
let sessions = [];
let loading = false;
Expand Down Expand Up @@ -356,9 +361,11 @@ export function mount(container, api) {
render();
fetchSessions();
if (autoRefresh) startAuto();
activeStopAuto = stopAuto;
}

export function unmount(container) {
if (activeStopAuto) { activeStopAuto(); activeStopAuto = null; }
container.innerHTML = '';
const styles = document.getElementById('sm-styles');
if (styles) styles.remove();
Expand Down