stratisd.spec: require dbus-python#572
Draft
mulkieran wants to merge 1 commit intostratis-storage:masterfrom
Draft
stratisd.spec: require dbus-python#572mulkieran wants to merge 1 commit intostratis-storage:masterfrom
mulkieran wants to merge 1 commit intostratis-storage:masterfrom
Conversation
This dependency should have been included when we started releasing stratis-decode-dm. The missing requirement never came to light because stratisd CI requires dbus-python for every relevant testing context where the missing dependency might have been discovered. Signed-off-by: mulhern <amulhern@redhat.com>
Member
Author
|
This better be a Recommends, not a hard Requires, for the same reasons that Clevis is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.