Add re.compile to prelude to avoid crash on regex imports#512
Draft
joehendrix wants to merge 2 commits intomainfrom
Draft
Add re.compile to prelude to avoid crash on regex imports#512joehendrix wants to merge 2 commits intomainfrom
joehendrix wants to merge 2 commits intomainfrom
Conversation
joehendrix
requested review from
a team,
fabiomadge and
keyboardDrummer
as code owners
joehendrix
force-pushed
the
jhx/pyspec_re
branch
from
ac19eab to
6dfa37f
Compare
Simplify dialect-loading by replacing the pure `preloaded` field with a
mutable `IO.Ref`, eliminating the need to thread `LoadedDialects` through
return types across every call site.
- Replace `DialectFileMap.preloaded` with `DialectFileMap.loaded : IO.Ref
LoadedDialects`; add `new`, `getLoaded`, `modifyLoaded` helpers
- Remove the `LoadedDialects` element from return tuples in the mutual
block (`loadDialectFromIonFragment`, `loadDialectFromPath`,
`loadDialectRec`, `elabDialectRest`) and public wrappers (`loadDialect`,
`elabDialect`)
- Remove `DialectState.loaded` field; add `getLoadedDialects` helper in
`DialectM` that reads directly from `DialectContext.loadedRef`,
eliminating the sync pattern and stale-snapshot risk
- Simplify `LoadDialectCallback` from
`LoadedDialects → DialectName → BaseIO (LoadedDialects × Except ...)`
to `DialectName → BaseIO (Except ...)`
- Simplify `readStrataText`, `readStrataIon`, `readFile` return types in
Util/IO and SimpleAPI from `IO (LoadedDialects × ...)` to `IO ...`
- Make `loadDialectFromPath` private; add public `loadDialectFromFile`
wrapper for the `#load_dialect` call site in HashCommands
- Extract `readDialectTextfileHeader` from the mutual block for header
parsing; inline `readDialectTextfile` body into `loadDialectFromPath`
- Preload production dialects (Core, Laurel, SMT, SMTCore, SMTResponse,
smtReservedKeywordsDialect) in `buildDialectFileMap` alongside Python
and PythonSpecs
- Change `DialectFileMap.ofDirs` to accept an `init` parameter and
`addEntry` to preserve existing map fields with `{ m with ... }`
- Fix `printCommand` to use `exitFailure` instead of silent return on
internal error
- Fix line lengths and complete truncated `DialectFileMap` docstring
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add re.compile to prelude so `from re import compile` resolves - Thread eventSet through PySpecContext for structured logging - Add --skip flag to pySpecs to skip top-level definitions while preserving @overload signatures - Register imported names as opaque extern types when module resolution fails, preventing downstream unknown-identifier errors - Skip body processing for overload stubs whose body is `...` Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
joehendrix
force-pushed
the
jhx/pyspec_re
branch
from
6dfa37f to
18c5efb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
re.compileas a known prelude identifier so thatfrom re import compileresolves without trying to find a localre.pyfile.from re import compilefor regexpattern validation assertions. Without this change, 370 of 411 service
files fail with
re.py not found.compile(...)calls inside assert statements produce"unrecognized assert pattern" warnings, which is expected since regex
matching isn't translated to specs.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.