HW UART - Remove repetitive NVIC SetPriority calls#1227
Merged
fpistm merged 1 commit intoNov 3, 2020
Merged
Conversation
Was impossible to change the UART IRQ's priority externally. Now only set once upon initialization.
Contributor
Author
|
Thanks! |
Member
|
Welcome @AbsoluteCatalyst |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Is there any purpose behind the NVIC UART IRQ priority being repetitively set within uart_attach_tx_callback and uart_attach_rx_callback rather than only at initialization?
Unfortunately this prevents any runtime/external changes done to the IRQ priority since it'd constantly be reset.
If there's no problem having it this way:
I've quickly removed the two extra setPriority calls and replaced them with a single call at init().