adding missing i2c2 SCL pinmap for DISCO_F407G#1203
Merged
Conversation
fpistm
approved these changes
Oct 16, 2020
fpistm
left a comment
fpistm
left a comment
Member
There was a problem hiding this comment.
Thanks.
I guess it was commented because the pin is the mic clk.
Anyway it can be used for other stuff if mic is not used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DISCO_F407G has a pinmap for i2c2 SDA but the matching i2c2 SCL pinmap is commented. This means i2c2 is unusable as there is not SCL pinmap for i2c2.
Simply uncommenting the line fixes the issue.
Validation
I have this board and have tested that the change allows me to use i2c2 with an AS5600 i2c device.
Closing issues
None