Skip to content

feat: add C implementation for stats/base/dists/betaprime/logcdf - #14676

Open
Planeshifter wants to merge 1 commit into
philipp/betaprime-cdf-cfrom
philipp/betaprime-logcdf-c
Open

feat: add C implementation for stats/base/dists/betaprime/logcdf#14676
Planeshifter wants to merge 1 commit into
philipp/betaprime-cdf-cfrom
philipp/betaprime-logcdf-c

Conversation

@Planeshifter

@Planeshifter Planeshifter commented Aug 27, 2026

Copy link
Copy Markdown
Member

Resolves #3439.

Description

What is the purpose of this pull request?

This pull request:

  • adds a C implementation and Node-API native addon for @stdlib/stats/base/dists/betaprime/logcdf, including C headers, GYP/Makefile build configurations, JavaScript/C benchmarks and examples, native unit tests, and README documentation updates. The implementation applies the transformation x/(1+x) before delegating to @stdlib/stats/base/dists/beta/logcdf, mirroring the JavaScript implementation.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

This PR was written primarily by Claude Code, using the stats/base/dists/betaprime/cdf and betaprime/pdf C implementations as templates; the changes were reviewed and validated locally (native addon built against the #13649 branch, all native tests passing) before submission.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Statistics Issue or pull request related to statistical functionality. label Aug 27, 2026
@Planeshifter Planeshifter changed the title philipp/betaprime logcdf c feat: add C implementation for stats/base/dists/betaprime/logcdf Aug 27, 2026
@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label Aug 27, 2026
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_kebab_filenames
    status: passed
---

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@Planeshifter
Planeshifter force-pushed the philipp/betaprime-logcdf-c branch from ce93891 to 2715126 Compare August 27, 2026 03:30
@Planeshifter Planeshifter added the METR Pull request associated with the METR project. label Aug 27, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/betaprime/cdf $\\color{green}333/333$
$\\color{green}+100.00\\%$
$\\color{green}29/29$
$\\color{green}+100.00\\%$
$\\color{green}4/4$
$\\color{green}+100.00\\%$
$\\color{green}333/333$
$\\color{green}+100.00\\%$
stats/base/dists/betaprime/logcdf $\\color{green}335/335$
$\\color{green}+100.00\\%$
$\\color{green}29/29$
$\\color{green}+100.00\\%$
$\\color{green}4/4$
$\\color{green}+100.00\\%$
$\\color{green}335/335$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

@stdlib-js stdlib-js deleted a comment from stdlib-bot Aug 27, 2026
@Planeshifter
Planeshifter marked this pull request as ready for review August 27, 2026 05:15
@Planeshifter
Planeshifter requested a review from a team August 27, 2026 05:15
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Aug 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue. METR Pull request associated with the METR project. Needs Review A pull request which needs code review. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/betaprime/logcdf

2 participants