Skip to content

style: remove extra trailing newlines#13016

Merged
kgryte merged 1 commit into
developfrom
philipp/fix-propagation-2026-06-21
Jun 21, 2026
Merged

style: remove extra trailing newlines#13016
kgryte merged 1 commit into
developfrom
philipp/fix-propagation-2026-06-21

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Description

Propagating fixes merged to develop between b04b44547c (2026-06-20 14:32 PDT) and e6e7d42b10 (2026-06-21 02:36 PDT) to sibling packages.

This pull request:

  • Removes the extra trailing blank line at EOF from 22 Makefiles under math/base/special/* and one Makefile under stats/base/dists/halfnormal/logpdf that exhibit the identical EOF pattern fixed in 50a34cff (style: remove extra trailing newlines). The source commit removed a single trailing blank line from five files under stats/base/dists/planck; the same one-byte fix applies verbatim here. Targets — all 23 ending .PHONY: clean\n\n (or, for halfnormal/logpdf/benchmark/c/Makefile, \n\n\n):

    • @stdlib/math/base/special/acos/src/Makefile
    • @stdlib/math/base/special/acosd/src/Makefile
    • @stdlib/math/base/special/acosdf/src/Makefile
    • @stdlib/math/base/special/acosh/src/Makefile
    • @stdlib/math/base/special/acoshf/src/Makefile
    • @stdlib/math/base/special/asinh/src/Makefile
    • @stdlib/math/base/special/asinhf/src/Makefile
    • @stdlib/math/base/special/atan/src/Makefile
    • @stdlib/math/base/special/atan2/src/Makefile
    • @stdlib/math/base/special/atan2d/src/Makefile
    • @stdlib/math/base/special/atanh/src/Makefile
    • @stdlib/math/base/special/besselj1/src/Makefile
    • @stdlib/math/base/special/cosh/src/Makefile
    • @stdlib/math/base/special/coshf/src/Makefile
    • @stdlib/math/base/special/erf/src/Makefile
    • @stdlib/math/base/special/erfc/src/Makefile
    • @stdlib/math/base/special/erfcinv/src/Makefile
    • @stdlib/math/base/special/erfcx/src/Makefile
    • @stdlib/math/base/special/erfinv/src/Makefile
    • @stdlib/math/base/special/kernel-cos/benchmark/c/native/Makefile
    • @stdlib/math/base/special/kernel-sincos/benchmark/c/native/Makefile
    • @stdlib/math/base/special/kernel-sincosf/benchmark/c/native/Makefile
    • @stdlib/stats/base/dists/halfnormal/logpdf/benchmark/c/Makefile

    Each file now ends with exactly one \n, conforming to the repository-wide insert_final_newline = true and trim_trailing_whitespace = true .editorconfig directives.

Related Issues

None.

Questions

No.

Other

Generated by an automated fix-propagation routine over the 15 commits merged to develop in the 24h window ending 2026-06-21. Four other source commits were inspected and dropped during pattern specification or pre-validation:

  • 1f05813f (docs: fix note — t-entropy v < 0v <= 0) — sibling t-distribution packages either already use <= semantics or are validly defined at v = 0 (e.g. t/median, t/mode return 0.0 at v = 0), so the doc-text correction does not apply.
  • b3383d13 (fix: use correct element typetypedndarray<number>typedndarray<unknown> for the generic gindex-of-falsy) — the only direct-parameter sibling (gindex-of-truthy) is already on <unknown>; remaining g-prefixed packages legitimately constrain elements to number for sum/cumsum/axpy arithmetic.
  • 7f1c224c (docs: update descriptions — anglit/mean Greek symbols, σ > 0 constraint, EvaluatesReturns) — the only anglit sibling (anglit/median) already carries both edits.
  • 5c56631c (test: fix mismatched test filenames) and 7f87b929 (chore: fix JavaScript lint errors) — no concrete grep-able search signature; dropped at pattern specification.

Validation

Two independent opus validation passes verified each target file ends with at least one trailing blank line after .PHONY: clean, carries no Do not manually edit / AUTOGENERATED marker, and is not the artifact of a template generator. A sonnet style-consistency pass sampled 20 sibling Makefiles and the root .editorconfig to confirm "single newline at EOF" is the dominant convention. Deliberately excluded from this PR:

  • gypi/Makefile files under other namespaces that did not exhibit the trailing-blank-line pattern (scan covered 4,926 Makefiles and 1,500 include.gypi files repo-wide).
  • Source commits whose pattern produced zero confirmed propagation sites after sibling-package inspection (see "Other" above).

Checklist

AI Assistance

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

This PR was authored by Claude Code on behalf of @Planeshifter as an automated propagation of fixes merged to develop over the prior 24 hours. Candidate source commits were filtered for generalizable patterns, sibling sites located via grep-able pattern signatures, and each proposed patch independently validated by parallel reviewer agents before commits were applied in the primary worktree. A human will audit and promote the PR out of draft.


@stdlib-js/reviewers


Generated by Claude Code

Propagates fix from 50a34cf ("style: remove extra trailing newlines")
to sibling Makefiles ending with `.PHONY: clean\n\n` (or, in one case,
`\n\n\n`). The source commit removed a single trailing blank line from
five files under `stats/base/dists/planck`; this commit applies the same
mechanical fix to 22 Makefiles under `math/base/special/*` and one
Makefile under `stats/base/dists/halfnormal/logpdf` that exhibit the
identical EOF pattern. Each file now ends with exactly one `\n`,
conforming to the repository-wide `insert_final_newline` /
`trim_trailing_whitespace` editorconfig directives.
@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
math/base/special/acos $\\color{green}217/217$
$\\color{green}+100.00\\%$
$\\color{green}12/12$
$\\color{green}+100.00\\%$
$\\color{green}2/2$
$\\color{green}+100.00\\%$
$\\color{green}217/217$
$\\color{green}+100.00\\%$
math/base/special/acosd $\\color{green}177/177$
$\\color{green}+100.00\\%$
$\\color{green}5/5$
$\\color{green}+100.00\\%$
$\\color{green}2/2$
$\\color{green}+100.00\\%$
$\\color{green}177/177$
$\\color{green}+100.00\\%$
math/base/special/acosdf $\\color{green}185/185$
$\\color{green}+100.00\\%$
$\\color{green}5/5$
$\\color{green}+100.00\\%$
$\\color{green}2/2$
$\\color{green}+100.00\\%$
$\\color{green}185/185$
$\\color{green}+100.00\\%$
math/base/special/acosh $\\color{green}217/217$
$\\color{green}+100.00\\%$
$\\color{green}14/14$
$\\color{green}+100.00\\%$
$\\color{green}2/2$
$\\color{green}+100.00\\%$
$\\color{green}217/217$
$\\color{green}+100.00\\%$
math/base/special/acoshf $\\color{green}226/226$
$\\color{green}+100.00\\%$
$\\color{green}14/14$
$\\color{green}+100.00\\%$
$\\color{green}2/2$
$\\color{green}+100.00\\%$
$\\color{green}226/226$
$\\color{green}+100.00\\%$
math/base/special/asinh $\\color{green}235/235$
$\\color{green}+100.00\\%$
$\\color{green}19/19$
$\\color{green}+100.00\\%$
$\\color{green}2/2$
$\\color{green}+100.00\\%$
$\\color{green}235/235$
$\\color{green}+100.00\\%$
math/base/special/asinhf $\\color{green}245/245$
$\\color{green}+100.00\\%$
$\\color{green}19/19$
$\\color{green}+100.00\\%$
$\\color{green}2/2$
$\\color{green}+100.00\\%$
$\\color{green}245/245$
$\\color{green}+100.00\\%$
math/base/special/atan $\\color{green}346/346$
$\\color{green}+100.00\\%$
$\\color{green}33/33$
$\\color{green}+100.00\\%$
$\\color{green}4/4$
$\\color{green}+100.00\\%$
$\\color{green}346/346$
$\\color{green}+100.00\\%$
math/base/special/atan2 $\\color{green}290/290$
$\\color{green}+100.00\\%$
$\\color{green}26/26$
$\\color{green}+100.00\\%$
$\\color{green}2/2$
$\\color{green}+100.00\\%$
$\\color{green}290/290$
$\\color{green}+100.00\\%$
math/base/special/atan2d $\\color{green}192/192$
$\\color{green}+100.00\\%$
$\\color{green}5/5$
$\\color{green}+100.00\\%$
$\\color{green}2/2$
$\\color{green}+100.00\\%$
$\\color{green}192/192$
$\\color{green}+100.00\\%$
math/base/special/atanh $\\color{green}248/248$
$\\color{green}+100.00\\%$
$\\color{green}24/24$
$\\color{green}+100.00\\%$
$\\color{green}2/2$
$\\color{green}+100.00\\%$
$\\color{green}248/248$
$\\color{green}+100.00\\%$
math/base/special/besselj1 $\\color{red}507/515$
$\\color{green}+98.45\\%$
$\\color{red}42/48$
$\\color{green}+87.50\\%$
$\\color{green}6/6$
$\\color{green}+100.00\\%$
$\\color{red}507/515$
$\\color{green}+98.45\\%$
math/base/special/cosh $\\color{green}203/203$
$\\color{green}+100.00\\%$
$\\color{green}11/11$
$\\color{green}+100.00\\%$
$\\color{green}2/2$
$\\color{green}+100.00\\%$
$\\color{green}203/203$
$\\color{green}+100.00\\%$
math/base/special/coshf $\\color{green}217/217$
$\\color{green}+100.00\\%$
$\\color{green}12/12$
$\\color{green}+100.00\\%$
$\\color{green}2/2$
$\\color{green}+100.00\\%$
$\\color{green}217/217$
$\\color{green}+100.00\\%$
math/base/special/erf $\\color{red}870/882$
$\\color{green}+98.64\\%$
$\\color{red}52/58$
$\\color{green}+89.66\\%$
$\\color{green}10/10$
$\\color{green}+100.00\\%$
$\\color{red}870/882$
$\\color{green}+98.64\\%$
math/base/special/erfc $\\color{red}895/907$
$\\color{green}+98.68\\%$
$\\color{red}55/61$
$\\color{green}+90.16\\%$
$\\color{green}10/10$
$\\color{green}+100.00\\%$
$\\color{red}895/907$
$\\color{green}+98.68\\%$
math/base/special/erfcinv $\\color{red}630/659$
$\\color{green}+95.60\\%$
$\\color{red}43/56$
$\\color{green}+76.79\\%$
$\\color{green}7/7$
$\\color{green}+100.00\\%$
$\\color{red}630/659$
$\\color{green}+95.60\\%$
math/base/special/erfcx $\\color{red}1368/1443$
$\\color{green}+94.80\\%$
$\\color{green}95/95$
$\\color{green}+100.00\\%$
$\\color{red}79/104$
$\\color{green}+75.96\\%$
$\\color{red}1368/1443$
$\\color{green}+94.80\\%$
math/base/special/erfinv $\\color{red}648/677$
$\\color{green}+95.72\\%$
$\\color{red}43/56$
$\\color{green}+76.79\\%$
$\\color{green}7/7$
$\\color{green}+100.00\\%$
$\\color{red}648/677$
$\\color{green}+95.72\\%$
math/base/special/kernel-cos $\\color{red}326/330$
$\\color{green}+98.79\\%$
$\\color{red}9/11$
$\\color{green}+81.82\\%$
$\\color{green}4/4$
$\\color{green}+100.00\\%$
$\\color{red}326/330$
$\\color{green}+98.79\\%$
math/base/special/kernel-sincos $\\color{red}395/403$
$\\color{green}+98.01\\%$
$\\color{red}15/19$
$\\color{green}+78.95\\%$
$\\color{green}6/6$
$\\color{green}+100.00\\%$
$\\color{red}395/403$
$\\color{green}+98.01\\%$
math/base/special/kernel-sincosf $\\color{green}413/413$
$\\color{green}+100.00\\%$
$\\color{green}19/19$
$\\color{green}+100.00\\%$
$\\color{green}6/6$
$\\color{green}+100.00\\%$
$\\color{green}413/413$
$\\color{green}+100.00\\%$
stats/base/dists/halfnormal/logpdf $\\color{red}303/305$
$\\color{green}+99.34\\%$
$\\color{red}19/20$
$\\color{green}+95.00\\%$
$\\color{green}4/4$
$\\color{green}+100.00\\%$
$\\color{red}303/305$
$\\color{green}+99.34\\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte marked this pull request as ready for review June 21, 2026 20:49
@kgryte kgryte requested a review from a team June 21, 2026 20:49
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jun 21, 2026
@kgryte kgryte changed the title style: remove extra trailing newlines from C Makefiles style: remove extra trailing newlines Jun 21, 2026
@kgryte kgryte merged commit 9a4e514 into develop Jun 21, 2026
37 checks passed
@kgryte kgryte deleted the philipp/fix-propagation-2026-06-21 branch June 21, 2026 20:49
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Jun 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants