use relative fontsize for model size numbers #556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@jgabry I'm asking your opinion on this PR. See also the issue for more explanation |
Member
|
I think 0.7 * base_size is a reasonable choice |
Collaborator
|
Should we make this change conditional on ggplot version so we don't require ggplot2 >= 4? |
aloctavodia
reviewed
Jan 22, 2026
aloctavodia
approved these changes
Jan 22, 2026
Member
|
I also use version checking with ggplot2 in bayesplot. We currently only require at least v3.4 so for some things we now check if the user has v4.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #555
This would add requirement that ggplot2 version needs to be at least 4.*