docs(contributing): fix Node.js version specification#235
Merged
BowTiedRadone merged 2 commits intostacks-network:masterfrom Mar 3, 2026
Merged
docs(contributing): fix Node.js version specification#235BowTiedRadone merged 2 commits intostacks-network:masterfrom
BowTiedRadone merged 2 commits intostacks-network:masterfrom
Conversation
BowTiedRadone
requested changes
Mar 2, 2026
Contributor
BowTiedRadone
left a comment
BowTiedRadone
left a comment
There was a problem hiding this comment.
@jadonamite Thanks for your PR! Left a suggestion. After you apply it we can merge.
jadonamite
commented
Mar 3, 2026
Contributor
Author
jadonamite
left a comment
jadonamite
left a comment
There was a problem hiding this comment.
Seen the changes would be made now
Contributor
Author
|
Changes done |
BowTiedRadone
approved these changes
Mar 3, 2026
Contributor
BowTiedRadone
left a comment
BowTiedRadone
left a comment
There was a problem hiding this comment.
LGTM. Thanks for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Node.js requirement in CONTRIBUTING.md was slightly inaccurate in two ways:
As i was initially very confused trying to figure out if my own version was supported or a downgrade was needed
This PR corrects the wording to "Node.js v20.18.0 (LTS) or later" and adds a
clear note that versions 20, 22, and 24 are all supported.