feat(albwaf): onboard WAF#1612
Open
SerseusWasTaken wants to merge 1 commit into
Open
Conversation
SerseusWasTaken
force-pushed
the
feat/onboard-waf-resource
branch
3 times, most recently
from
July 27, 2026 08:22
6cbea1f to
3a169c3
Compare
SerseusWasTaken
commented
Jul 27, 2026
| mapvalidator.KeysAre( | ||
| stringvalidator.RegexMatches( | ||
| // Regex validates that no stackit- prefix is used | ||
| regexp.MustCompile(`^(?:[a-zA-Z0-9]|[a-zA-Z0-9][a-zA-Z0-9_.-]{0,6}[a-zA-Z0-9]|(?:[a-rt-zA-Z0-9][a-zA-Z0-9_.-]{7}|s[a-su-zA-Z0-9_.-][a-zA-Z0-9_.-]{6}|st[b-zA-Z0-9_.-][a-zA-Z0-9_.-]{5}|sta[a-bd-zA-Z0-9_.-][a-zA-Z0-9_.-]{4}|stac[a-jl-zA-Z0-9_.-][a-zA-Z0-9_.-]{3}|stack[a-hj-zA-Z0-9_.-][a-zA-Z0-9_.-]{2}|stacki[a-su-zA-Z0-9_.-][a-zA-Z0-9_.-]|stackit[a-zA-Z0-9_.])[a-zA-Z0-9_.-]{0,54}[a-zA-Z0-9])$`), |
Contributor
Author
There was a problem hiding this comment.
This regex is ridiculously complex, but only because negative lookaheads not possible are using regexp.MustCompile.
SerseusWasTaken
force-pushed
the
feat/onboard-waf-resource
branch
from
July 27, 2026 08:33
3a169c3 to
f5b35c4
Compare
Relates to STACKITTPR-749
SerseusWasTaken
force-pushed
the
feat/onboard-waf-resource
branch
from
July 27, 2026 09:08
f5b35c4 to
0226c30
Compare
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to STACKITTPR-749
Description
Onboards WAF
Checklist
make fmtexamples/directory)make generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)