Repository navigation
fix(configurator): preserve broad Firewall setup decisions - #122
Merged
Merged
Conversation
Always resolve active Firewall setup scope with the source-grounded classifier; general HA field hints must not skip remaining business decisions. Preserve explicit narrow updates and null-only evidence for long native requests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
5 of 9 tasks
lweberru
marked this pull request as ready for review
October 20, 2026 11:38
lweberru
requested review from
BackInBash,
Breeless,
JoshSTACKIT,
LembDo and
dweezl
as code owners
October 20, 2026 11:38
lweberru
enabled auto-merge (squash)
October 20, 2026 11:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
Protected Dev release 39412434669, merged source
0c5188bf60c332adcbecf5372e913021b298e126, passed 113/114 model cases and 13/13 journey steps, with no transport failures.firewall-metro-setup-operations, repetition 1, omitted the still-unanswered interruption/operations question. Build and deployment were skipped; the original failed receipt remains retained.The general intent classifier could label a broad “continue the central Firewall setup with HA” request with
firewallFields=[ha]. That field hint bypassed the dedicated setup-scope/evidence classifier, making a broad continuation behave like a narrow HA-only update. Native proposal validation did not detect the omitted conversational decision.Changes
hafield hints, explicit narrow changes after broad history, and empty quote inventories.Validation
npm run check: 977 passed, 69 unchanged default-gated cases; lint, types and build passed.Qwen/Qwen3-VL-235B-A22B-Instruct-FP8; execution was disabled and only the dedicated inference token was used.0fd2c183ebdf903b2e7d10e50dac5e4b3abd08e9f665fcc15bbab01b95669299; unchanged factual suite SHA:8c60fd19e7e5a6e8903ccea7987f834112c948b4de8cb60487a1694bc64fe2ee.81acc9da14b7665b5733373773f7e8c608a51b2b; committed content manifest retained with the local receipts. No transport failures occurred during this qualification.Release boundary
Refs #95. Dev has not been changed by the failed release. After normal reviewed integration, a new manual exact-source release must pass its complete repeated model gate before building and deploying with
runner_pool_size=1, then verify hosted warm handoff and replacement readiness.Previous failures remain failures. No failed iteration was retried as a replacement receipt, no oracle was weakened, and no customer Apply or production operation was performed.