Skip to content

fix(configurator): preserve broad Firewall setup decisions - #122

Merged
lweberru merged 1 commit into
mainfrom
fix/configurator-firewall-setup-scope
Oct 20, 2026
Merged

lweberru merged 1 commit into
mainfrom
fix/configurator-firewall-setup-scope

Conversation

@lweberru

@lweberru lweberru commented Oct 20, 2026 •

Copy link
Copy Markdown
Collaborator

Root cause

Protected Dev release 39412434669, merged source 0c5188bf60c332adcbecf5372e913021b298e126, passed 113/114 model cases and 13/13 journey steps, with no transport failures. firewall-metro-setup-operations, repetition 1, omitted the still-unanswered interruption/operations question. Build and deployment were skipped; the original failed receipt remains retained.

The general intent classifier could label a broad “continue the central Firewall setup with HA” request with firewallFields=[ha]. That field hint bypassed the dedicated setup-scope/evidence classifier, making a broad continuation behave like a narrow HA-only update. Native proposal validation did not detect the omitted conversational decision.

Changes

  • Always consult the existing dedicated scope/evidence classifier for active Firewall drafts and multi-turn Firewall conversations, independently of general field hints.
  • Keep the existing semantic distinction: broad setup asks only the next unanswered business decision; explicit narrow native changes do not acquire unrelated setup questions, including after earlier broad setup.
  • Use null-only evidence fields when no bounded quote fragments exist, rather than emitting empty enumerations for a newly classified long native request.
  • Add six regression cases covering every remaining/complete setup stage despite ha field hints, explicit narrow changes after broad history, and empty quote inventories.
  • Adapt mock classifier responses and positional schema assertions to the additional classification call, preserving all semantic expectations and the no-extra-answer-model contract for missing native IPs.
  • Update complete EN/DE guidance and regenerate source bindings. No curated topic facts, model defaults, native infrastructure, or factual oracle changed.

Validation

  • Red reproduction: four valid Metro setup cases demonstrated the bypass before the runtime correction.
  • Pinned Node 24.21.0/npm 11.19.0 canonical npm run check: 977 passed, 69 unchanged default-gated cases; lint, types and build passed.
  • Real configured-model Firewall cases: 28/28 passed, two independent repetitions; continuous dialogue 13/13 passed, both exit 0. Both answer and intent models remain Qwen/Qwen3-VL-235B-A22B-Instruct-FP8; execution was disabled and only the dedicated inference token was used.
  • Knowledge SHA: 0fd2c183ebdf903b2e7d10e50dac5e4b3abd08e9f665fcc15bbab01b95669299; unchanged factual suite SHA: 8c60fd19e7e5a6e8903ccea7987f834112c948b4de8cb60487a1694bc64fe2ee.
  • Exact qualified source: 81acc9da14b7665b5733373773f7e8c608a51b2b; committed content manifest retained with the local receipts. No transport failures occurred during this qualification.

Release boundary

Refs #95. Dev has not been changed by the failed release. After normal reviewed integration, a new manual exact-source release must pass its complete repeated model gate before building and deploying with runner_pool_size=1, then verify hosted warm handoff and replacement readiness.

Previous failures remain failures. No failed iteration was retried as a replacement receipt, no oracle was weakened, and no customer Apply or production operation was performed.

Always resolve active Firewall setup scope with the source-grounded classifier; general HA field hints must not skip remaining business decisions. Preserve explicit narrow updates and null-only evidence for long native requests.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@lweberru
lweberru marked this pull request as ready for review October 20, 2026 11:38
@lweberru
lweberru enabled auto-merge (squash) October 20, 2026 11:38
@lweberru
lweberru merged commit d0fc3d3 into main Oct 20, 2026
13 checks passed
@lweberru
lweberru deleted the fix/configurator-firewall-setup-scope branch October 20, 2026 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant