feat: allow custom annotations and lower default acme TTL - #226
Merged
Conversation
This was referenced Aug 25, 2026
fsandel
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and configuration enhancements to the Helm chart and codebase for the
stackit-cert-manager-webhook. The most significant change is lowering the default ACME TXT record TTL from 600 to 60 seconds, with corresponding updates in documentation and tests. Additionally, the Helm chart now supports custom annotations at various resource levels, increasing flexibility for deployments.Lastly, removes the ActiveEq(true) filter in FetchRRSetForZone so the webhook can discover and clean up ACME records that are still in a CREATING state. Soft-deleted records (DELETED/DELETING) are now explicitly filtered out
in-memory to prevent updates to tombstoned resources.