Skip to content

Conversation

@sbernauer
Copy link
Member

Description

Should basically make no difference, but quicker feedback.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@sbernauer sbernauer self-assigned this Jan 16, 2026
@sbernauer sbernauer moved this to Development: Waiting for Review in Stackable Engineering Jan 16, 2026
xeniape
xeniape previously approved these changes Jan 19, 2026
@xeniape xeniape moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Jan 19, 2026
Copy link
Member

@xeniape xeniape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests passed locally for me :) but seemed flaky (might be on my side, didn't look too much into it)

@sbernauer sbernauer added this pull request to the merge queue Jan 19, 2026
Merged via the queue into main with commit 62b3f40 Jan 19, 2026
10 checks passed
@sbernauer sbernauer deleted the test/iceberg-opa-assert branch January 19, 2026 09:42
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Jan 19, 2026
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Jan 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants