Repository navigation
Conversation
Signed-off-by: Sebastian Turner <sebastiant3484@gmail.com>
oldergod
approved these changes
Oct 19, 2026
Member
|
Thank you for contributing. Once you signed our CLA, I'll merge the PR. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JsonIntegration.mapKeyJsonFormatter()had no case forProtoAdapter.BOOL, so creating a Moshi or Gson adapter for any message with amap<bool, V>field threwIllegalStateException: Unexpected map key type: class kotlin.Boolean.This adds a formatter that writes bool keys as
"true"and"false", as the proto3 JSON mapping specifies, and parses them back. Other strings are rejected.Test: added a
MapBoolKeysmessage to the sharedmap_types.protofixture and amapBoolKeyscase toWireJsonTest, which runs against the Kotlin and Java generated code for every Moshi and Gson configuration. It fails without the change and passes with it.Fixes #3732