Fix multiple EXPLAIN output formatting issues #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes several EXPLAIN AST output issues: 1. SampleRatio formatting: Convert decimal ratios like 0.1 to fractions like 1/10 to match ClickHouse EXPLAIN AST output 2. CHECK TABLE FORMAT clause: Add support for parsing and outputting the FORMAT clause in CHECK TABLE statements 3. Materialized view ViewTargets: For CREATE MATERIALIZED VIEW statements, output the AS SELECT clause before the storage definition and wrap storage definition in ViewTargets 4. OPTIMIZE TABLE PARTITION: Add support for outputting the PARTITION clause in OPTIMIZE TABLE statements These fixes resolve 44 test statements across many test files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes several EXPLAIN AST output issues:
SampleRatio formatting: Convert decimal ratios like 0.1 to fractions
like 1/10 to match ClickHouse EXPLAIN AST output
CHECK TABLE FORMAT clause: Add support for parsing and outputting the
FORMAT clause in CHECK TABLE statements
Materialized view ViewTargets: For CREATE MATERIALIZED VIEW statements,
output the AS SELECT clause before the storage definition and wrap
storage definition in ViewTargets
OPTIMIZE TABLE PARTITION: Add support for outputting the PARTITION
clause in OPTIMIZE TABLE statements
These fixes resolve 44 test statements across many test files.