Fix CAST alias and large float formatting in EXPLAIN output #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Always show alias for CAST expressions when wrapped in AliasedExpr, regardless of whether CAST uses AS syntax (CAST(x AS Type)) or comma syntax (CAST(x, 'Type')) - Use scientific notation for very large floats (>= 1e21) in EXPLAIN output to match ClickHouse's behavior - Update next-test command to show test with most pending statements instead of fewest These changes fix 69 test files with numerous explain_todo statements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always show alias for CAST expressions when wrapped in AliasedExpr,
regardless of whether CAST uses AS syntax (CAST(x AS Type)) or comma
syntax (CAST(x, 'Type'))
Use scientific notation for very large floats (>= 1e21) in EXPLAIN
output to match ClickHouse's behavior
Update next-test command to show test with most pending statements
instead of fewest
These changes fix 69 test files with numerous explain_todo statements.