Skip to content

Fix Dictionary range EXPLAIN output to not include children #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kyleconroy merged 1 commit into from
Dec 30, 2025
Merged

Fix Dictionary range EXPLAIN output to not include children #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 2 additions & 18 deletions internal/explain/dictionary.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,23 +153,7 @@ func explainDictionaryLayout(sb *strings.Builder, n *ast.DictionaryLayout, inden
}

// explainDictionaryRange outputs a dictionary RANGE clause.
// Note: ClickHouse's EXPLAIN does not output children for Dictionary range.
func explainDictionaryRange(sb *strings.Builder, n *ast.DictionaryRange, indent string, depth int) {
children := 0
if n.Min != nil {
children++
}
if n.Max != nil {
children++
}
if children > 0 {
fmt.Fprintf(sb, "%sDictionary range (children %d)\n", indent, children)
if n.Min != nil {
Node(sb, n.Min, depth+1)
}
if n.Max != nil {
Node(sb, n.Max, depth+1)
}
} else {
fmt.Fprintf(sb, "%sDictionary range\n", indent)
}
fmt.Fprintf(sb, "%sDictionary range\n", indent)
}
6 changes: 1 addition & 5 deletions parser/testdata/03553_inconsistent_formatting_of_dictionary/metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1 @@
{
"explain_todo": {
"stmt1": true
}
}
{}