Add database-qualified name support in EXPLAIN AST output #103
+39
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix EXPLAIN AST output for database-qualified table names in: - DetachQuery: Output separate database and table identifiers - AttachQuery: Output separate database and table identifiers - InsertQuery: Output separate database and table identifiers - CreateQuery: Output separate database and table identifiers When a query references a table as "database.table", ClickHouse's EXPLAIN AST outputs them as two separate Identifier children rather than a single combined "database.table" identifier. This fixes 46 out of 65 failing statements in the 01601_detach_permanently test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix EXPLAIN AST output for database-qualified table names in:
When a query references a table as "database.table", ClickHouse's
EXPLAIN AST outputs them as two separate Identifier children rather
than a single combined "database.table" identifier.
This fixes 46 out of 65 failing statements in the
01601_detach_permanently test.