Fix octopus_saving_session regex#3710
Open
Meatballs1 wants to merge 6 commits intospringfall2008:mainfrom
Open
Fix octopus_saving_session regex#3710Meatballs1 wants to merge 6 commits intospringfall2008:mainfrom
Meatballs1 wants to merge 6 commits intospringfall2008:mainfrom
Conversation
Contributor
Contributor
Author
|
Thought it wouldn't be too tedious fixing them in the web interface but I was wrong :) |
Contributor
Thanks! I started doing the same then pulled up the IDE and then saw your PR as I was about to start 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missing parenthesis causing exceptions/crashes.
Better fix would be to also catch the exception and print the offending line to the log.