Skip to content

Use static imports for Assertions.assertThat() consistently #48630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
izeye wants to merge 1 commit into from
Closed

Use static imports for Assertions.assertThat() consistently #48630

izeye wants to merge 1 commit into from

Conversation

@izeye
Copy link
Contributor

@izeye izeye commented Dec 28, 2025

This PR changes to use static imports for Assertions.assertThat() consistently where possible.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 28, 2025
snicoll
snicoll reviewed Dec 28, 2025
View reviewed changes
Copy link
Member

@snicoll snicoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. We are not using the static import in assert implementations (main code). I think we should keep it this way. WDYT?

@izeye
Copy link
Contributor Author

izeye commented Dec 28, 2025 •
edited
Loading

@snicoll Thanks for the feedback!

I don't have a strong opinion on it. I just thought that it's prefered based on the following changes: 90faddf#diff-e9d603edb2e72b3fc962233b6ae08d6391b61bb776bc86ce2039df7860f05866R233

@snicoll
Copy link
Member

snicoll commented Dec 29, 2025

Good point, I remember reviewing this and then going with it as the OP is an AssertJ maintainer but I think we may want to reconsider this. I'll flag for team attention to get more feedback.

@snicoll snicoll added for: team-attention An issue we'd like other members of the team to review type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Dec 29, 2025
@snicoll snicoll added this to the 3.5.x milestone Dec 29, 2025
@Pankraz76

This comment was marked as resolved.

Sign in to view
Pankraz76 pushed a commit to Pankraz76/spring-boot that referenced this pull request Dec 29, 2025
Add JupiterBestPractices spring-projects#48630
a596f0a 
Signed-off-by: Vincent Potucek <[email protected]>
Pankraz76 pushed a commit to Pankraz76/spring-boot that referenced this pull request Jan 4, 2026
Add SanityCheck#EqualityRulesRecipes spring-projects#48630
4e141e0 
Signed-off-by: Vincent Potucek <[email protected]>

```
Changes have been made to build-plugin/spring-boot-maven-plugin/src/main/java/org/springframework/boot/maven/ClassPath.java by:
    tech.picnic.errorprone.refasterrules.FileRulesRecipes
        tech.picnic.errorprone.refasterrules.FileRulesRecipes$PathOfUriRecipe
Changes have been made to buildpack/spring-boot-buildpack-platform/src/main/java/org/springframework/boot/buildpack/platform/io/InspectedContent.java by:
    tech.picnic.errorprone.refasterrules.FileRulesRecipes
        tech.picnic.errorprone.refasterrules.FileRulesRecipes$FilesCreateTempFileToFileRecipe
Changes have been made to buildpack/spring-boot-buildpack-platform/src/main/java/org/springframework/boot/buildpack/platform/build/Cache.java by:
    tech.picnic.errorprone.refasterrules.EqualityRulesRecipes
        tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$EnumReferenceEqualityRecipe
Changes have been made to buildpack/spring-boot-buildpack-platform/src/main/java/org/springframework/boot/buildpack/platform/build/BuildpackReference.java by:
    tech.picnic.errorprone.refasterrules.FileRulesRecipes
        tech.picnic.errorprone.refasterrules.FileRulesRecipes$PathOfUriRecipe
Changes have been made to buildpack/spring-boot-buildpack-platform/src/test/java/org/springframework/boot/buildpack/platform/docker/configuration/DockerConfigurationMetadataTests.java by:
    tech.picnic.errorprone.refasterrules.FileRulesRecipes
        tech.picnic.errorprone.refasterrules.FileRulesRecipes$PathOfUriRecipe
Changes have been made to buildpack/spring-boot-buildpack-platform/src/test/java/org/springframework/boot/buildpack/platform/docker/configuration/ResolvedDockerHostTests.java by:
    tech.picnic.errorprone.refasterrules.FileRulesRecipes
        tech.picnic.errorprone.refasterrules.FileRulesRecipes$PathOfUriRecipe
Changes have been made to buildpack/spring-boot-buildpack-platform/src/test/java/org/springframework/boot/buildpack/platform/build/EphemeralBuilderTests.java by:
    tech.picnic.errorprone.refasterrules.TimeRulesRecipes
        tech.picnic.errorprone.refasterrules.TimeRulesRecipes$UtcConstantRecipe
        tech.picnic.errorprone.refasterrules.TimeRulesRecipes$InstantAtOffsetRecipe
Changes have been made to buildpack/spring-boot-buildpack-platform/src/test/java/org/springframework/boot/buildpack/platform/build/BuildRequestTests.java by:
    tech.picnic.errorprone.refasterrules.TimeRulesRecipes
        tech.picnic.errorprone.refasterrules.TimeRulesRecipes$UtcConstantRecipe
Changes have been made to buildpack/spring-boot-buildpack-platform/src/test/java/org/springframework/boot/buildpack/platform/build/ImageBuildpackTests.java by:
    tech.picnic.errorprone.refasterrules.FileRulesRecipes
        tech.picnic.errorprone.refasterrules.FileRulesRecipes$FilesCreateTempFileToFileRecipe
Changes have been made to cli/spring-boot-cli/src/test/resources/commands/command.groovy by:
    org.openrewrite.java.format.RemoveTrailingWhitespace
Changes have been made to cli/spring-boot-cli/src/test/resources/dir-sample/code/app.groovy by:
    org.openrewrite.java.format.RemoveTrailingWhitespace
Changes have been made to cli/spring-boot-cli/src/test/resources/scripts/closure.groovy by:
    org.openrewrite.java.format.RemoveTrailingWhitespace
Changes have been made to cli/spring-boot-cli/src/test/resources/scripts/command.groovy by:
    org.openrewrite.java.format.RemoveTrailingWhitespace
Changes have been made to core/spring-boot/src/test/java/org/springframework/boot/info/SslInfoTests.java by:
    tech.picnic.errorprone.refasterrules.TimeRulesRecipes
        tech.picnic.errorprone.refasterrules.TimeRulesRecipes$UtcConstantRecipe
Changes have been made to core/spring-boot/src/test/java/org/springframework/boot/logging/AbstractLoggingSystemTests.java by:
    tech.picnic.errorprone.refasterrules.FileRulesRecipes
        tech.picnic.errorprone.refasterrules.FileRulesRecipes$FilesCreateTempFileToFileRecipe
Changes have been made to core/spring-boot/src/test/java/org/springframework/boot/convert/PeriodToStringConverterTests.java by:
    tech.picnic.errorprone.refasterrules.TimeRulesRecipes
        tech.picnic.errorprone.refasterrules.TimeRulesRecipes$ZeroPeriodRecipe
Changes have been made to core/spring-boot/src/test/java/org/springframework/boot/convert/PeriodStyleTests.java by:
    tech.picnic.errorprone.refasterrules.TimeRulesRecipes
        tech.picnic.errorprone.refasterrules.TimeRulesRecipes$ZeroPeriodRecipe
Changes have been made to core/spring-boot-test/src/main/java/org/springframework/boot/test/util/TestPropertyValues.java by:
    tech.picnic.errorprone.refasterrules.EqualityRulesRecipes
        tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$EnumReferenceEqualityRecipe
Changes have been made to core/spring-boot-test/src/main/java/org/springframework/boot/test/system/OutputCapture.java by:
    tech.picnic.errorprone.refasterrules.EqualityRulesRecipes
        tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$EnumReferenceEqualityLambdaRecipe
Changes have been made to loader/spring-boot-loader/src/main/java/org/springframework/boot/loader/net/protocol/nested/NestedUrlConnection.java by:
    tech.picnic.errorprone.refasterrules.TimeRulesRecipes
        tech.picnic.errorprone.refasterrules.TimeRulesRecipes$UtcConstantRecipe
Changes have been made to loader/spring-boot-loader-tools/src/main/java/org/springframework/boot/loader/tools/SizeCalculatingEntryWriter.java by:
    tech.picnic.errorprone.refasterrules.FileRulesRecipes
        tech.picnic.errorprone.refasterrules.FileRulesRecipes$FilesCreateTempFileToFileRecipe
Changes have been made to module/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/web/exchanges/HttpExchange.java by:
    tech.picnic.errorprone.refasterrules.TimeRulesRecipes
        tech.picnic.errorprone.refasterrules.TimeRulesRecipes$ClockInstantRecipe
Changes have been made to module/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/management/HeapDumpWebEndpoint.java by:
    tech.picnic.errorprone.refasterrules.FileRulesRecipes
        tech.picnic.errorprone.refasterrules.FileRulesRecipes$FilesCreateTempFileToFileRecipe
Changes have been made to module/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/info/InfoPropertiesInfoContributor.java by:
    tech.picnic.errorprone.refasterrules.EqualityRulesRecipes
        tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$EnumReferenceEqualityRecipe
Changes have been made to module/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/endpoint/invoker/cache/CachingOperationInvoker.java by:
    tech.picnic.errorprone.refasterrules.EqualityRulesRecipes
        tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$EnumReferenceEqualityRecipe
Changes have been made to module/spring-boot-devtools/src/main/java/org/springframework/boot/devtools/filewatch/ChangedFile.java by:
    tech.picnic.errorprone.refasterrules.EqualityRulesRecipes
        tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$EnumReferenceEqualityRecipe
Changes have been made to module/spring-boot-devtools/src/test/java/org/springframework/boot/devtools/restart/MainMethodTests.java by:
    org.openrewrite.staticanalysis.ReplaceLambdaWithMethodReference
Changes have been made to module/spring-boot-jetty/src/main/java/org/springframework/boot/jetty/autoconfigure/JettyWebServerFactoryCustomizer.java by:
    tech.picnic.errorprone.refasterrules.EqualityRulesRecipes
        tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$EnumReferenceEqualityRecipe
Changes have been made to module/spring-boot-jetty/src/test/java/org/springframework/boot/jetty/autoconfigure/JettyWebServerFactoryCustomizerTests.java by:
    tech.picnic.errorprone.refasterrules.FileRulesRecipes
        tech.picnic.errorprone.refasterrules.FileRulesRecipes$FilesCreateTempFileToFileRecipe
Changes have been made to module/spring-boot-kafka/src/main/java/org/springframework/boot/kafka/autoconfigure/ConcurrentKafkaListenerContainerFactoryConfigurer.java by:
    tech.picnic.errorprone.refasterrules.EqualityRulesRecipes
        tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$EnumReferenceEqualityRecipe
Changes have been made to module/spring-boot-micrometer-metrics/src/main/java/org/springframework/boot/micrometer/metrics/autoconfigure/ssl/SslMeterBinder.java by:
    tech.picnic.errorprone.refasterrules.TimeRulesRecipes
        tech.picnic.errorprone.refasterrules.TimeRulesRecipes$ClockInstantRecipe
Changes have been made to module/spring-boot-micrometer-metrics/src/test/java/org/springframework/boot/micrometer/metrics/autoconfigure/ssl/SslMeterBinderTests.java by:
    tech.picnic.errorprone.refasterrules.TimeRulesRecipes
        tech.picnic.errorprone.refasterrules.TimeRulesRecipes$UtcConstantRecipe
Changes have been made to module/spring-boot-security/src/test/java/org/springframework/boot/security/autoconfigure/UserDetailsServiceAutoConfigurationTests.java by:
    tech.picnic.errorprone.refasterrules.EqualityRulesRecipes
        tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$EnumReferenceEqualityLambdaRecipe
Changes have been made to module/spring-boot-sql/src/main/java/org/springframework/boot/sql/autoconfigure/init/OnDatabaseInitializationCondition.java by:
    tech.picnic.errorprone.refasterrules.EqualityRulesRecipes
        tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$EnumReferenceEqualityRecipe
        tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$NegationRecipe
Changes have been made to module/spring-boot-tomcat/src/test/java/org/springframework/boot/tomcat/servlet/TomcatServletWebServerFactoryTests.java by:
    org.openrewrite.staticanalysis.ReplaceLambdaWithMethodReference
Changes have been made to module/spring-boot-webflux/src/test/java/org/springframework/boot/webflux/observation/autoconfigure/WebFluxObservationAutoConfigurationTests.java by:
    tech.picnic.errorprone.refasterrules.TimeRulesRecipes
        tech.picnic.errorprone.refasterrules.TimeRulesRecipes$DurationOfSecondsRecipe
Changes have been made to module/spring-boot-zipkin/src/main/java/org/springframework/boot/zipkin/autoconfigure/ZipkinHttpClientSender.java by:
    org.openrewrite.staticanalysis.ReplaceLambdaWithMethodReference
Changes have been made to test-support/spring-boot-test-support/src/main/java/org/springframework/boot/testsupport/classpath/resources/Resources.java by:
    tech.picnic.errorprone.refasterrules.FileRulesRecipes
        tech.picnic.errorprone.refasterrules.FileRulesRecipes$PathOfUriRecipe
Changes have been made to test-support/spring-boot-test-support/src/main/java/org/springframework/boot/testsupport/system/OutputCapture.java by:
    tech.picnic.errorprone.refasterrules.EqualityRulesRecipes
        tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$EnumReferenceEqualityLambdaRecipe
Please review and commit the results.
Estimate time saved: 3h 6m

BUILD SUCCESSFUL in 18m 9s
```
Pankraz76 pushed a commit to Pankraz76/spring-boot that referenced this pull request Jan 4, 2026
Add SanityCheck#EqualityRulesRecipes spring-projects#48630
1a3ce30 
Signed-off-by: Vincent Potucek <[email protected]>

```
Changes have been made to build-plugin/spring-boot-maven-plugin/src/main/java/org/springframework/boot/maven/ClassPath.java by:
    tech.picnic.errorprone.refasterrules.FileRulesRecipes
        tech.picnic.errorprone.refasterrules.FileRulesRecipes$PathOfUriRecipe
Changes have been made to buildpack/spring-boot-buildpack-platform/src/main/java/org/springframework/boot/buildpack/platform/io/InspectedContent.java by:
    tech.picnic.errorprone.refasterrules.FileRulesRecipes
        tech.picnic.errorprone.refasterrules.FileRulesRecipes$FilesCreateTempFileToFileRecipe
Changes have been made to buildpack/spring-boot-buildpack-platform/src/main/java/org/springframework/boot/buildpack/platform/build/Cache.java by:
    tech.picnic.errorprone.refasterrules.EqualityRulesRecipes
        tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$EnumReferenceEqualityRecipe
Changes have been made to buildpack/spring-boot-buildpack-platform/src/main/java/org/springframework/boot/buildpack/platform/build/BuildpackReference.java by:
    tech.picnic.errorprone.refasterrules.FileRulesRecipes
        tech.picnic.errorprone.refasterrules.FileRulesRecipes$PathOfUriRecipe
Changes have been made to buildpack/spring-boot-buildpack-platform/src/test/java/org/springframework/boot/buildpack/platform/docker/configuration/DockerConfigurationMetadataTests.java by:
    tech.picnic.errorprone.refasterrules.FileRulesRecipes
        tech.picnic.errorprone.refasterrules.FileRulesRecipes$PathOfUriRecipe
Changes have been made to buildpack/spring-boot-buildpack-platform/src/test/java/org/springframework/boot/buildpack/platform/docker/configuration/ResolvedDockerHostTests.java by:
    tech.picnic.errorprone.refasterrules.FileRulesRecipes
        tech.picnic.errorprone.refasterrules.FileRulesRecipes$PathOfUriRecipe
Changes have been made to buildpack/spring-boot-buildpack-platform/src/test/java/org/springframework/boot/buildpack/platform/build/EphemeralBuilderTests.java by:
    tech.picnic.errorprone.refasterrules.TimeRulesRecipes
        tech.picnic.errorprone.refasterrules.TimeRulesRecipes$UtcConstantRecipe
        tech.picnic.errorprone.refasterrules.TimeRulesRecipes$InstantAtOffsetRecipe
Changes have been made to buildpack/spring-boot-buildpack-platform/src/test/java/org/springframework/boot/buildpack/platform/build/BuildRequestTests.java by:
    tech.picnic.errorprone.refasterrules.TimeRulesRecipes
        tech.picnic.errorprone.refasterrules.TimeRulesRecipes$UtcConstantRecipe
Changes have been made to buildpack/spring-boot-buildpack-platform/src/test/java/org/springframework/boot/buildpack/platform/build/ImageBuildpackTests.java by:
    tech.picnic.errorprone.refasterrules.FileRulesRecipes
        tech.picnic.errorprone.refasterrules.FileRulesRecipes$FilesCreateTempFileToFileRecipe
Changes have been made to cli/spring-boot-cli/src/test/resources/commands/command.groovy by:
    org.openrewrite.java.format.RemoveTrailingWhitespace
Changes have been made to cli/spring-boot-cli/src/test/resources/dir-sample/code/app.groovy by:
    org.openrewrite.java.format.RemoveTrailingWhitespace
Changes have been made to cli/spring-boot-cli/src/test/resources/scripts/closure.groovy by:
    org.openrewrite.java.format.RemoveTrailingWhitespace
Changes have been made to cli/spring-boot-cli/src/test/resources/scripts/command.groovy by:
    org.openrewrite.java.format.RemoveTrailingWhitespace
Changes have been made to core/spring-boot/src/test/java/org/springframework/boot/info/SslInfoTests.java by:
    tech.picnic.errorprone.refasterrules.TimeRulesRecipes
        tech.picnic.errorprone.refasterrules.TimeRulesRecipes$UtcConstantRecipe
Changes have been made to core/spring-boot/src/test/java/org/springframework/boot/logging/AbstractLoggingSystemTests.java by:
    tech.picnic.errorprone.refasterrules.FileRulesRecipes
        tech.picnic.errorprone.refasterrules.FileRulesRecipes$FilesCreateTempFileToFileRecipe
Changes have been made to core/spring-boot/src/test/java/org/springframework/boot/convert/PeriodToStringConverterTests.java by:
    tech.picnic.errorprone.refasterrules.TimeRulesRecipes
        tech.picnic.errorprone.refasterrules.TimeRulesRecipes$ZeroPeriodRecipe
Changes have been made to core/spring-boot/src/test/java/org/springframework/boot/convert/PeriodStyleTests.java by:
    tech.picnic.errorprone.refasterrules.TimeRulesRecipes
        tech.picnic.errorprone.refasterrules.TimeRulesRecipes$ZeroPeriodRecipe
Changes have been made to core/spring-boot-test/src/main/java/org/springframework/boot/test/util/TestPropertyValues.java by:
    tech.picnic.errorprone.refasterrules.EqualityRulesRecipes
        tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$EnumReferenceEqualityRecipe
Changes have been made to core/spring-boot-test/src/main/java/org/springframework/boot/test/system/OutputCapture.java by:
    tech.picnic.errorprone.refasterrules.EqualityRulesRecipes
        tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$EnumReferenceEqualityLambdaRecipe
Changes have been made to loader/spring-boot-loader/src/main/java/org/springframework/boot/loader/net/protocol/nested/NestedUrlConnection.java by:
    tech.picnic.errorprone.refasterrules.TimeRulesRecipes
        tech.picnic.errorprone.refasterrules.TimeRulesRecipes$UtcConstantRecipe
Changes have been made to loader/spring-boot-loader-tools/src/main/java/org/springframework/boot/loader/tools/SizeCalculatingEntryWriter.java by:
    tech.picnic.errorprone.refasterrules.FileRulesRecipes
        tech.picnic.errorprone.refasterrules.FileRulesRecipes$FilesCreateTempFileToFileRecipe
Changes have been made to module/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/web/exchanges/HttpExchange.java by:
    tech.picnic.errorprone.refasterrules.TimeRulesRecipes
        tech.picnic.errorprone.refasterrules.TimeRulesRecipes$ClockInstantRecipe
Changes have been made to module/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/management/HeapDumpWebEndpoint.java by:
    tech.picnic.errorprone.refasterrules.FileRulesRecipes
        tech.picnic.errorprone.refasterrules.FileRulesRecipes$FilesCreateTempFileToFileRecipe
Changes have been made to module/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/info/InfoPropertiesInfoContributor.java by:
    tech.picnic.errorprone.refasterrules.EqualityRulesRecipes
        tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$EnumReferenceEqualityRecipe
Changes have been made to module/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/endpoint/invoker/cache/CachingOperationInvoker.java by:
    tech.picnic.errorprone.refasterrules.EqualityRulesRecipes
        tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$EnumReferenceEqualityRecipe
Changes have been made to module/spring-boot-devtools/src/main/java/org/springframework/boot/devtools/filewatch/ChangedFile.java by:
    tech.picnic.errorprone.refasterrules.EqualityRulesRecipes
        tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$EnumReferenceEqualityRecipe
Changes have been made to module/spring-boot-devtools/src/test/java/org/springframework/boot/devtools/restart/MainMethodTests.java by:
    org.openrewrite.staticanalysis.ReplaceLambdaWithMethodReference
Changes have been made to module/spring-boot-jetty/src/main/java/org/springframework/boot/jetty/autoconfigure/JettyWebServerFactoryCustomizer.java by:
    tech.picnic.errorprone.refasterrules.EqualityRulesRecipes
        tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$EnumReferenceEqualityRecipe
Changes have been made to module/spring-boot-jetty/src/test/java/org/springframework/boot/jetty/autoconfigure/JettyWebServerFactoryCustomizerTests.java by:
    tech.picnic.errorprone.refasterrules.FileRulesRecipes
        tech.picnic.errorprone.refasterrules.FileRulesRecipes$FilesCreateTempFileToFileRecipe
Changes have been made to module/spring-boot-kafka/src/main/java/org/springframework/boot/kafka/autoconfigure/ConcurrentKafkaListenerContainerFactoryConfigurer.java by:
    tech.picnic.errorprone.refasterrules.EqualityRulesRecipes
        tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$EnumReferenceEqualityRecipe
Changes have been made to module/spring-boot-micrometer-metrics/src/main/java/org/springframework/boot/micrometer/metrics/autoconfigure/ssl/SslMeterBinder.java by:
    tech.picnic.errorprone.refasterrules.TimeRulesRecipes
        tech.picnic.errorprone.refasterrules.TimeRulesRecipes$ClockInstantRecipe
Changes have been made to module/spring-boot-micrometer-metrics/src/test/java/org/springframework/boot/micrometer/metrics/autoconfigure/ssl/SslMeterBinderTests.java by:
    tech.picnic.errorprone.refasterrules.TimeRulesRecipes
        tech.picnic.errorprone.refasterrules.TimeRulesRecipes$UtcConstantRecipe
Changes have been made to module/spring-boot-security/src/test/java/org/springframework/boot/security/autoconfigure/UserDetailsServiceAutoConfigurationTests.java by:
    tech.picnic.errorprone.refasterrules.EqualityRulesRecipes
        tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$EnumReferenceEqualityLambdaRecipe
Changes have been made to module/spring-boot-sql/src/main/java/org/springframework/boot/sql/autoconfigure/init/OnDatabaseInitializationCondition.java by:
    tech.picnic.errorprone.refasterrules.EqualityRulesRecipes
        tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$EnumReferenceEqualityRecipe
        tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$NegationRecipe
Changes have been made to module/spring-boot-tomcat/src/test/java/org/springframework/boot/tomcat/servlet/TomcatServletWebServerFactoryTests.java by:
    org.openrewrite.staticanalysis.ReplaceLambdaWithMethodReference
Changes have been made to module/spring-boot-webflux/src/test/java/org/springframework/boot/webflux/observation/autoconfigure/WebFluxObservationAutoConfigurationTests.java by:
    tech.picnic.errorprone.refasterrules.TimeRulesRecipes
        tech.picnic.errorprone.refasterrules.TimeRulesRecipes$DurationOfSecondsRecipe
Changes have been made to module/spring-boot-zipkin/src/main/java/org/springframework/boot/zipkin/autoconfigure/ZipkinHttpClientSender.java by:
    org.openrewrite.staticanalysis.ReplaceLambdaWithMethodReference
Changes have been made to test-support/spring-boot-test-support/src/main/java/org/springframework/boot/testsupport/classpath/resources/Resources.java by:
    tech.picnic.errorprone.refasterrules.FileRulesRecipes
        tech.picnic.errorprone.refasterrules.FileRulesRecipes$PathOfUriRecipe
Changes have been made to test-support/spring-boot-test-support/src/main/java/org/springframework/boot/testsupport/system/OutputCapture.java by:
    tech.picnic.errorprone.refasterrules.EqualityRulesRecipes
        tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$EnumReferenceEqualityLambdaRecipe
Please review and commit the results.
Estimate time saved: 3h 6m

BUILD SUCCESSFUL in 18m 9s
```
@Pankraz76 Pankraz76 mentioned this pull request Jan 4, 2026
Closed
@Pankraz76

This comment was marked as resolved.

Sign in to view
@wilkinsona
Copy link
Member

wilkinsona commented Jan 5, 2026

I don't feel particularly strongly about it, but I lean towards consistently using the static import in both main and test code.

Pankraz76 pushed a commit to Pankraz76/spring-boot that referenced this pull request Jan 5, 2026
Add UseStaticImport spring-projects#48630
0417e12 
Signed-off-by: Vincent Potucek <[email protected]>
Pankraz76 pushed a commit to Pankraz76/spring-boot that referenced this pull request Jan 5, 2026
Add UseStaticImport spring-projects#48630
da8537f 
Signed-off-by: Vincent Potucek <[email protected]>
@philwebb
Copy link
Member

philwebb commented Jan 5, 2026

I don't have a strong opinion in either direction.

@snicoll
Copy link
Member

snicoll commented Jan 5, 2026

Cool, thanks both. Let's go with the consistent option to use the static import then.

@snicoll snicoll removed the for: team-attention An issue we'd like other members of the team to review label Jan 5, 2026
@snicoll snicoll self-assigned this Jan 5, 2026
@snicoll snicoll mentioned this pull request Jan 6, 2026
Closed
snicoll pushed a commit that referenced this pull request Jan 6, 2026
@izeye @snicoll
Use static imports for Assertions.assertThat() consistently
88f51fa 
See gh-48630

Signed-off-by: Johnny Lim <[email protected]>
snicoll added a commit that referenced this pull request Jan 6, 2026
@snicoll
Polish "Use static imports for Assertions.assertThat() consistently"
918325a 
See gh-48630
@snicoll snicoll closed this in c10cf59 Jan 6, 2026
@snicoll snicoll modified the milestones: 3.5.x, 3.5.10 Jan 6, 2026
@izeye izeye deleted the assert-that branch January 6, 2026 12:51
@Pankraz76
Copy link

Pankraz76 commented Jan 6, 2026

Cool, thanks both. Let's go with the consistent option to use the static import then.

Does this mean the rule? It reads like so because consistency can only be achieved via some gatekeeper, which is currently not the case, as discovered in:

philwebb added a commit that referenced this pull request Jan 6, 2026
@philwebb
Add checkstyle rule for AssertJ Assertions import
92263e7 
Add a rule to ensure we consistently use `assertThat` rather than
`Assertions.assertThat`.

See gh-48630
@philwebb
Copy link
Member

philwebb commented Jan 6, 2026

@Pankraz76 Good idea, I've added a rule in 92263e7

philwebb added a commit that referenced this pull request Jan 6, 2026
@philwebb
Fix Assertions static imports
581f648 
See gh-48630
@Pankraz76
Copy link

Pankraz76 commented Jan 7, 2026

ah nice thx, yes check also capable of doing, so we having all parties happy.

Got some gate keeper and no new tool.

well done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@snicoll snicoll snicoll left review comments

Assignees

@snicoll snicoll

Labels

type: task A general task

Projects

None yet

Milestone

3.5.10

Development

Successfully merging this pull request may close these issues.

6 participants

@izeye @snicoll @Pankraz76 @wilkinsona @philwebb @spring-projects-issues