Repository navigation
controlplane: no role erases a volume's signed history, and runners read who wrote it - #25
Merged
Merged
Conversation
…ead who wrote it spin F6: - a restore takes, of every version of a volume's HEAD, the highest-sequence one its writer signed; - it holds that HEAD to the writer's record under writers/. The boundary now denies s3:DeleteObjectVersion on volumes/*/HEAD and writers/* for every role. Past the bucket's lock, erasing the newest HEADs of a volume nobody wrote since would be a rollback a restore believes. Nothing in spin lifts a delete marker there: a workspace's delete is the database's soft delete until the volume is crypto-shredded. The runner scope reads writers/* and writes none of it. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
F6c (spin F6, spec spin#259).
What changes
s3:DeleteObjectVersiononvolumes/*/HEADandwriters/*for every role, with no condition.object_lock_days, the lock no longer keeps a version. Erasing the newest HEADs of a volume nobody wrote since would be a rollback a restore believes.DeleteObjectVersion, becauseRestorelifts a delete marker, which is a version. As you pointed out, the UI's delete and restore are the database's soft delete (trashed_until), and a purge crypto-shreds the volume. So nothing in spin needs to lift a marker on a HEAD or a writer's record.writers/*, to hold a HEAD to its writer, and writes none of it. Only the control plane says who a writer is.spin's per-host session policy needs the same reads (spin#264). Without both, a restore on AWS is refused.
Tests
a_volumes_signed_history_is_erased_by_nobody. It checks:BypassGovernanceRetentiondenied;writers/*;task lintpasses: 42 module tests.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.