Skip to content

session: allow clients to query server.version after negotitation #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
x1ddos wants to merge 1 commit into from
Closed

session: allow clients to query server.version after negotitation #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions docs/protocol-changes.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,8 @@ Removed methods
* :func:`blockchain.block.get_header`
* :func:`blockchain.block.get_chunk`

.. _version 1.4.1:

Version 1.4.1
=============

Expand All @@ -158,11 +160,18 @@ Changes
nonzero. AuxPoW data is still present when *cp_height* is zero.
Non-AuxPoW chains are unaffected.


Version 1.4.1
=============

New methods
-----------

* :func:`blockchain.scipthash.unsubscribe` to unsubscribe from a script hash.

.. _version 1.4.2:

Version 1.4.2
=============

Changes
-------

* :func:`server.version` now always reports the current versions in use;
however, only the first message performs protocol negotiation.
4 changes: 3 additions & 1 deletion docs/protocol-methods.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -968,7 +968,9 @@ server.version
==============

Identify the client to the server and negotiate the protocol version.
Only the first :func:`server.version` message is accepted.
The first :func:`server.version` message performs the protocol version
negotiation as described below. Subsequent calls simply return the negotiated
version.

**Signature**

Expand Down
2 changes: 1 addition & 1 deletion electrumx/server/session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1337,7 +1337,7 @@ async def server_version(self, client_name='', protocol_version=None):
'''
self.bump_cost(0.5)
if self.sv_seen:
raise RPCError(BAD_REQUEST, f'server.version already sent')
return electrumx.version, self.protocol_version_string()
self.sv_seen = True

if client_name:
Expand Down