Fix some validation edge cases due to over optimisations in validate --fast#785
Conversation
… --fast` Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
🤖 Augment PR SummarySummary: This PR updates the vendored Blaze dependency and fixes validation edge-cases introduced by aggressive Changes:
Technical Notes: The intent is to preserve correctness while keeping the fast validator’s closure-elision optimizations when they are provably redundant. 🤖 Was this summary useful? React with 👍 or 👎 |
| } | ||
|
|
||
| if (inner.is_object()) { | ||
| schema.merge(inner.as_object()); |
There was a problem hiding this comment.
vendor/blaze/src/alterschema/canonicalizer/disallow_double_negation.h:68 — schema.merge(inner.as_object()) will overwrite any existing wrapper-node members with the inner schema’s members; if the wrapper carries location-affecting keywords (e.g., id), collapsing the negation chain could unintentionally change reference resolution/identifiers.
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
Signed-off-by: Juan Cruz Viotti jv@jviotti.com