Support dependentSchemas and dependentRequired on codegen#780
Merged
Conversation
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
🤖 Augment PR SummarySummary: This PR updates vendored dependencies to extend JSON Schema codegen support for the 2020-12 keywords Changes:
Technical notes: When using system OpenSSL for Core Crypto, the build now requires OpenSSL 3.0 APIs (used for key construction/verification). 🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
| target_link_libraries(sourcemeta_core_jose | ||
| PUBLIC sourcemeta::core::json) | ||
| target_link_libraries(sourcemeta_core_jose | ||
| PRIVATE sourcemeta::core::crypto) |
There was a problem hiding this comment.
vendor/core/src/core/jose/CMakeLists.txt:8 — sourcemeta_core_jose’s sources call into sourcemeta::core::crypto (e.g., JWK base64url decoding), so keeping that dependency PRIVATE may cause undefined symbols for consumers when building/linking static libs that only link sourcemeta::core::jose.
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
| crypto_sha2_64.h crypto_random.h crypto_helpers.h) | ||
|
|
||
| target_link_libraries(sourcemeta_core_crypto | ||
| PRIVATE sourcemeta::core::text sourcemeta::core::numeric) |
There was a problem hiding this comment.
vendor/core/src/core/crypto/CMakeLists.txt:8-9 — sourcemeta_core_crypto now uses sourcemeta::core::text/numeric symbols (e.g., bytes_to_hex, is_hex_digit), but these are linked PRIVATE; in static builds this can fail to link for downstreams that only link sourcemeta::core::crypto.
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Jun 18, 2026
⚠️ **CAUTION: this is a major update, indicating a breaking change!**⚠️ This MR contains the following updates: | Package | Update | Change | |---|---|---| | [sourcemeta/jsonschema](https://github.com/sourcemeta/jsonschema) | major | `v15.11.0` → `v16.0.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>sourcemeta/jsonschema (sourcemeta/jsonschema)</summary> ### [`v16.0.0`](https://github.com/sourcemeta/jsonschema/releases/tag/v16.0.0) [Compare Source](sourcemeta/jsonschema@v15.11.0...v16.0.0) #### What's Changed - Support bundled schemas with custom meta-schemas by [@​jviotti](https://github.com/jviotti) in [#​779](sourcemeta/jsonschema#779) - Support `dependentSchemas` and `dependentRequired` on `codegen` by [@​jviotti](https://github.com/jviotti) in [#​780](sourcemeta/jsonschema#780) #### Breaking Changes - Use system `libcurl` through `dlopen` on Linux/BSD by [@​jviotti](https://github.com/jviotti) in [#​781](sourcemeta/jsonschema#781) Before this release, the Linux pre-compiled binaries were built against a vendored static copy of cURL. While that worked in most cases, it relied on a very specific CA certificate store. Making it problematic if you need more runtime control over that in your actual target installation. So instead of linking against a specific version of cURL in the system (and therefore probably breaking some distros no matter what), we take a more dynamic approach: we can at runtime try to find an appropriate cURL library we can use (probing lots of popular paths across distros), and dynamically load it. Most Linux systems have cURL installed out of the box, otherwise you get a friendly runtime error instructing you on how to fix it or point to a custom one of your choice. **Full Changelog**: <sourcemeta/jsonschema@v15.11.0...v16.0.0> </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4yMjcuMSIsInVwZGF0ZWRJblZlciI6IjQzLjIyNy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiLCJhdXRvbWF0aW9uOmJvdC1hdXRob3JlZCIsImRlcGVuZGVuY3ktdHlwZTo6bWFqb3IiXX0=-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juan Cruz Viotti jv@jviotti.com