Skip to content

Upgrade Core to 1b3ab73db3f0a4dfe0e1ee1e59601a81bfe100fe#921

Merged
jviotti merged 2 commits into
mainfrom
fix-gcc
Jun 19, 2026
Merged

Upgrade Core to 1b3ab73db3f0a4dfe0e1ee1e59601a81bfe100fe#921
jviotti merged 2 commits into
mainfrom
fix-gcc

Conversation

@jviotti

@jviotti jviotti commented Jun 19, 2026

Copy link
Copy Markdown
Member

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Review in cubic

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Re-trigger cubic

@augmentcode

augmentcode Bot commented Jun 19, 2026

Copy link
Copy Markdown
🤖 Augment PR Summary

Summary: This PR updates the vendored sourcemeta/core dependency and incorporates upstream fixes.

Changes:

  • Bumps core to commit 1b3ab73d… via DEPENDENCIES
  • Updates ARM CRC32 implementation to use compiler builtins instead of including <arm_acle.h> (to avoid toolchain/header issues under Werror)
  • Refactors is_under_path to reuse a shared component-wise prefix check helper
  • Adds is_lexically_under_path for filesystem-independent, component-by-component path prefix checks

Technical Notes: The new lexical helper relies on lexically_normal()-based normalization and avoids filesystem resolution, while the canonical variant continues to use weakly_canonical().

🤖 Was this summary useful? React with 👍 or 👎

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestion posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

Comment thread vendor/core/src/lang/io/io.cc
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@jviotti jviotti merged commit c369ed6 into main Jun 19, 2026
13 checks passed
@jviotti jviotti deleted the fix-gcc branch June 19, 2026 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant