fix: return only one tag when git tag returns multiple#171
Open
imax9000 wants to merge 1 commit intosourcegraph:mainfrom
Open
fix: return only one tag when git tag returns multiple#171imax9000 wants to merge 1 commit intosourcegraph:mainfrom
git tag returns multiple#171imax9000 wants to merge 1 commit intosourcegraph:mainfrom
Conversation
This makes version inference work correctly on github.com/kubernetes/api, returning just "v0.34.1" instead of "kubernetes-1.34.1\nv0.34.1".
jupblb
requested changes
Mar 29, 2026
| "fmt" | ||
| "strings" | ||
|
|
||
| "github.com/Masterminds/semver" |
Member
There was a problem hiding this comment.
Please use golang.org/x/mod/semver instead
| return "", fmt.Errorf("failed to tags for current commit: %v\n%s", err, version) | ||
| return "", fmt.Errorf("failed to tags for current commit: %v\n%s", err, tags) | ||
| } | ||
| lines := strings.Split(tags, "\n") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes version inference work correctly on github.com/kubernetes/api, returning just "v0.34.1" instead of "kubernetes-1.34.1\nv0.34.1".