Skip to content

Apply review suggestions to license key docs - #2082

Merged
enriquegh merged 1 commit into
mainfrom
enrique/license-key-docs-review-followups
Oct 8, 2026
Merged

enriquegh merged 1 commit into
mainfrom
enrique/license-key-docs-review-followups

Conversation

@enriquegh

Copy link
Copy Markdown
Contributor

Applies two review suggestions from @bobheadxi on #2073 that came in after it merged:

  • admin/licensing: shorten the Sourcegraph Cloud note to say Sourcegraph manages the license key, without describing the hidden form (comment).
  • self-hosted/deploy/kubernetes/configure: name the exact page, Administration → Configuration → Product license (/admin/license) (comment).

Amp thread: https://ampcode.com/threads/T-2198952b-2156-4c41-95b8-3d5b5c963010

@vercel

vercel Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
sourcegraph-docs Ready Ready Preview Oct 8, 2026 10:50pm UTC

Request Review

@github-actions

github-actions Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Direct preview links to pages changed in this PR:

@github-actions

github-actions Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

⚠️ Spell check found 1 issue(s) in this PR

Only findings on lines added by this PR, and in its title and description, are shown.

Pull request description

  • line 1, column 38
    • bobheadxi → bowhead

Please correct the spelling, or add words which are correct to cspell-allow-list.txt.

Run npx cspell@10 --no-progress --dot '**/*' locally to check the full repository.

@bobheadxi bobheadxi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks again!

@enriquegh
enriquegh merged commit 86f3ac0 into main Oct 8, 2026
8 checks passed
@enriquegh
enriquegh deleted the enrique/license-key-docs-review-followups branch October 8, 2026 22:53
@bobheadxi

Copy link
Copy Markdown
Member

wow this is kind of rude

CleanShot 2026-10-08 at 15 52 59@2x

This branch was successfully deployed

1 active deployment
Preview — d66791ef Deployed Oct 8, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants